Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2418983002: ui/views: convert usage of FOR_EACH_OBSERVER macro (Closed)

Created:
4 years, 2 months ago by tfarina
Modified:
4 years, 2 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui/views: convert usage of FOR_EACH_OBSERVER macro ObserverList now supports range-based for loops and thus this can be used to iterate through a list of observers as the FOR_EACH_OBSERVER macro was deprecated. This patch was generated by the following command line: $ cd ui/views $ perl -0777 -pi -e 's/FOR_EACH_OBSERVER\(\s*([\w:]+?)\s*,\s*([\w:()]+?)\s*,\s*([^;]+?)\);/for (\1& observer : \2) observer.\3;/mg' $(git gs FOR_EACH_OBSERVER | cut -d: -f1 | uniq) And then manually inspected for line indentation fixes. BUG=655021 TEST=views_unittests R=sadrul@chromium.org Committed: https://crrev.com/725a3dbcf54b79a10d1eba8f8164f7e22d4dab06 Cr-Commit-Position: refs/heads/master@{#425359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -56 lines) Patch
M ui/views/animation/bounds_animator.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M ui/views/focus/focus_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/focus/widget_focus_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/mus/pointer_watcher_event_router.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/widget.cc View 8 chunks +23 lines, -20 lines 0 comments Download
M ui/views/win/windows_session_change_observer.cc View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
tfarina
4 years, 2 months ago (2016-10-14 03:23:23 UTC) #3
loyso (OOO)
LGTMed duplicate: https://codereview.chromium.org/2417463009/#
4 years, 2 months ago (2016-10-14 04:25:28 UTC) #6
loyso (OOO)
Plese, mark your intents in https://docs.google.com/spreadsheets/d/14u7dpq7NcBTtQj3hhEOrnA5Eq3Q9N_ON4w9pLCLC2cI/edit#gid=0
4 years, 2 months ago (2016-10-14 04:26:25 UTC) #7
loyso (OOO)
Let you choose, what to land. Explicit vs. implicit :)
4 years, 2 months ago (2016-10-14 04:30:53 UTC) #8
tfarina
On 2016/10/14 04:26:25, loyso wrote: > Plese, mark your intents in > https://docs.google.com/spreadsheets/d/14u7dpq7NcBTtQj3hhEOrnA5Eq3Q9N_ON4w9pLCLC2cI/edit#gid=0 I can't ...
4 years, 2 months ago (2016-10-14 12:10:50 UTC) #9
tfarina
On 2016/10/14 04:30:53, loyso wrote: > Let you choose, what to land. Explicit vs. implicit ...
4 years, 2 months ago (2016-10-14 12:11:55 UTC) #10
sky
sky->sadrul, I wouldn't want him to miss on the review fun of these patches ;)
4 years, 2 months ago (2016-10-14 15:56:29 UTC) #12
sadrul
lgtm
4 years, 2 months ago (2016-10-14 16:06:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418983002/1
4 years, 2 months ago (2016-10-14 16:42:02 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 16:49:22 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 16:53:17 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/725a3dbcf54b79a10d1eba8f8164f7e22d4dab06
Cr-Commit-Position: refs/heads/master@{#425359}

Powered by Google App Engine
This is Rietveld 408576698