Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: extensions/browser/guest_view/mime_handler_view/mime_handler_stream_manager.cc

Issue 2418963002: Don't abort the MimeHandlerStreamManager stream if we receive a RenderProcessHostChanged notificati… (Closed)
Patch Set: Add a check for whether the routing id and the pid of the old host is the same as the pair in Embed… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/guest_view/mime_handler_view/mime_handler_stream_ma nager.h" 5 #include "extensions/browser/guest_view/mime_handler_view/mime_handler_stream_ma nager.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/memory/singleton.h" 8 #include "base/memory/singleton.h"
9 #include "components/keyed_service/content/browser_context_dependency_manager.h" 9 #include "components/keyed_service/content/browser_context_dependency_manager.h"
10 #include "components/keyed_service/content/browser_context_keyed_service_factory .h" 10 #include "components/keyed_service/content/browser_context_keyed_service_factory .h"
(...skipping 214 matching lines...) Expand 10 before | Expand all | Expand 10 after
225 void MimeHandlerStreamManager::EmbedderObserver::DidStartNavigation( 225 void MimeHandlerStreamManager::EmbedderObserver::DidStartNavigation(
226 content::NavigationHandle* navigation_handle) { 226 content::NavigationHandle* navigation_handle) {
227 // If the top level frame is navigating away, clean up the stream. 227 // If the top level frame is navigating away, clean up the stream.
228 if (navigation_handle->IsInMainFrame()) 228 if (navigation_handle->IsInMainFrame())
229 AbortStream(); 229 AbortStream();
230 } 230 }
231 231
232 void MimeHandlerStreamManager::EmbedderObserver::RenderFrameHostChanged( 232 void MimeHandlerStreamManager::EmbedderObserver::RenderFrameHostChanged(
233 content::RenderFrameHost* old_host, 233 content::RenderFrameHost* old_host,
234 content::RenderFrameHost* new_host) { 234 content::RenderFrameHost* new_host) {
235 // If the old_host is null, then it means that a subframe is being created.
236 // Don't treat this like a host change.
237 if (!old_host)
238 return;
239
240 // If this is an unrelated host, ignore.
241 if ((old_host->GetRoutingID() != render_frame_id_) ||
242 (old_host->GetProcess()->GetID() != render_process_id_)) {
243 return;
244 }
245
235 new_host_ = new_host; 246 new_host_ = new_host;
236 // Update the RFID, RPIDs to those of the new RFH. This ensures 247 // Update the RFID, RPIDs to those of the new RFH. This ensures
237 // that if the new RFH gets deleted before loading the stream, we will 248 // that if the new RFH gets deleted before loading the stream, we will
238 // abort it. 249 // abort it.
239 DCHECK((frame_tree_node_id_ == -1) || 250 DCHECK((frame_tree_node_id_ == -1) ||
240 (frame_tree_node_id_ == new_host_->GetFrameTreeNodeId())); 251 (frame_tree_node_id_ == new_host_->GetFrameTreeNodeId()));
241 render_frame_id_ = new_host_->GetRoutingID(); 252 render_frame_id_ = new_host_->GetRoutingID();
242 render_process_id_ = new_host_->GetProcess()->GetID(); 253 render_process_id_ = new_host_->GetProcess()->GetID();
243 } 254 }
244 255
(...skipping 17 matching lines...) Expand all
262 if (frame_tree_node_id_ != -1) { 273 if (frame_tree_node_id_ != -1) {
263 return render_frame_host->GetFrameTreeNodeId() == frame_tree_node_id_; 274 return render_frame_host->GetFrameTreeNodeId() == frame_tree_node_id_;
264 } else { 275 } else {
265 DCHECK((render_frame_id_ != -1) && (render_process_id_ != -1)); 276 DCHECK((render_frame_id_ != -1) && (render_process_id_ != -1));
266 return render_frame_host->GetRoutingID() == render_frame_id_ && 277 return render_frame_host->GetRoutingID() == render_frame_id_ &&
267 render_frame_host->GetProcess()->GetID() == render_process_id_; 278 render_frame_host->GetProcess()->GetID() == render_process_id_;
268 } 279 }
269 } 280 }
270 281
271 } // namespace extensions 282 } // namespace extensions
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698