Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2418933004: Reduce usage of FOR_EACH_OBSERVER macro in base (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, sadrul, gavinp+memory_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce usage of FOR_EACH_OBSERVER macro in base Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/a60549cd31bee65971319a1afd1cae62f8e7fa07 Cr-Commit-Position: refs/heads/master@{#425580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -21 lines) Patch
M base/memory/memory_pressure_listener.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/message_loop/message_loop.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M base/observer_list_unittest.cc View 8 chunks +20 lines, -10 lines 0 comments Download
M base/process/port_provider_mac.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Eric Willigers
4 years, 2 months ago (2016-10-15 13:10:18 UTC) #4
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-15 23:49:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418933004/1
4 years, 2 months ago (2016-10-15 23:49:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-16 00:10:09 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-16 00:12:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a60549cd31bee65971319a1afd1cae62f8e7fa07
Cr-Commit-Position: refs/heads/master@{#425580}

Powered by Google App Engine
This is Rietveld 408576698