ImageCapture: avoid several grabFrame()s in flight, beef up content_browsertests

ImageCapture: avoid several grabFrame()s in flight, beef up content_browsertests

This CL limits to one the amount of grab-frame operations in
flight by adding a flag to ImageCaptureFrameGrabber, this
prevents hitting a DCHECK in debug, or doing wrong things
in !DCHECK_IS_ON() builds.

It also adds a content_browsertest for grabFrame() and
refactors the operations in that file a bit.

BUG=655900
TEST=see bug for reproduction cases

Committed: https://crrev.com/43f89e492ac625dd1e7e12a9ab2ee66282ddb31d
Cr-Commit-Position: refs/heads/master@{#425535}

[mcasas, 2016-10-14 14:13:29]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-10-14 14:13:39]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-10-14 21:05:53]

Description was changed from

==========
ImageCapture: avoid several grabFrame()s in flight, beef up content_browsertests

BUG=655900
==========

to

==========
ImageCapture: avoid several grabFrame()s in flight, beef up content_browsertests

This CL limits to one the amount of grab-frame operations in 
flight by adding a flag to ImageCaptureFrameGrabber, this
prevents hitting a DCHECK in debug, or doing wrong things
in !DCHECK_IS_ON() builds. 

It also adds a content_browsertest for grabFrame() and
refactors the operations in that file a bit.


BUG=655900
TEST=see bug for reproduction cases
==========

[mcasas, 2016-10-14 21:06:11]

mcasas@chromium.org changed reviewers:
+ xianglu@chromium.org

[mcasas, 2016-10-14 21:06:11]

xianglu@ PTAL

[xianglu, 2016-10-14 22:34:52]

https://codereview.chromium.org/2418923003/diff/60001/content/browser/webrtc/...
File content/browser/webrtc/webrtc_image_capture_browsertest.cc (right):

https://codereview.chromium.org/2418923003/diff/60001/content/browser/webrtc/...
content/browser/webrtc/webrtc_image_capture_browsertest.cc:118: if
(RunImageCaptureTestCase("testCreateAndGetCapabilities()"))
Consider using ASSERT_TRUE(), which can save two lines.

[xianglu, 2016-10-14 22:46:16]

lgtm.

[mcasas, 2016-10-14 22:50:34]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 22:50:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2016-10-14 23:04:04]

mcasas@chromium.org changed reviewers:
+ avi@chromium.org

[mcasas, 2016-10-14 23:04:04]

avi@ please RS changes to
 content/browser/webrtc/webrtc_image_capture_browsertest.cc

[commit-bot: I haz the power, 2016-10-15 00:31:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 00:31:56]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-10-15 00:50:39]

lgtm

stamp

[mcasas, 2016-10-15 02:07:43]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-10-15 02:07:43]

The patchset sent to the CQ was uploaded after l-g-t-m from xianglu@chromium.org
Link to the patchset: https://codereview.chromium.org/2418923003/#ps80001
(title: "xianglu@ comments")

[commit-bot: I haz the power, 2016-10-15 02:07:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 02:13:10]

Description was changed from

==========
ImageCapture: avoid several grabFrame()s in flight, beef up content_browsertests

This CL limits to one the amount of grab-frame operations in 
flight by adding a flag to ImageCaptureFrameGrabber, this
prevents hitting a DCHECK in debug, or doing wrong things
in !DCHECK_IS_ON() builds. 

It also adds a content_browsertest for grabFrame() and
refactors the operations in that file a bit.


BUG=655900
TEST=see bug for reproduction cases
==========

to

==========
ImageCapture: avoid several grabFrame()s in flight, beef up content_browsertests

This CL limits to one the amount of grab-frame operations in 
flight by adding a flag to ImageCaptureFrameGrabber, this
prevents hitting a DCHECK in debug, or doing wrong things
in !DCHECK_IS_ON() builds. 

It also adds a content_browsertest for grabFrame() and
refactors the operations in that file a bit.


BUG=655900
TEST=see bug for reproduction cases
==========

[commit-bot: I haz the power, 2016-10-15 02:13:11]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-10-15 02:16:24]

Description was changed from

==========
ImageCapture: avoid several grabFrame()s in flight, beef up content_browsertests

This CL limits to one the amount of grab-frame operations in 
flight by adding a flag to ImageCaptureFrameGrabber, this
prevents hitting a DCHECK in debug, or doing wrong things
in !DCHECK_IS_ON() builds. 

It also adds a content_browsertest for grabFrame() and
refactors the operations in that file a bit.


BUG=655900
TEST=see bug for reproduction cases
==========

to

==========
ImageCapture: avoid several grabFrame()s in flight, beef up content_browsertests

This CL limits to one the amount of grab-frame operations in
flight by adding a flag to ImageCaptureFrameGrabber, this
prevents hitting a DCHECK in debug, or doing wrong things
in !DCHECK_IS_ON() builds.

It also adds a content_browsertest for grabFrame() and
refactors the operations in that file a bit.

BUG=655900
TEST=see bug for reproduction cases

Committed: https://crrev.com/43f89e492ac625dd1e7e12a9ab2ee66282ddb31d
Cr-Commit-Position: refs/heads/master@{#425535}
==========

[commit-bot: I haz the power, 2016-10-15 02:16:25]

Patchset 3 (id:??) landed as
https://crrev.com/43f89e492ac625dd1e7e12a9ab2ee66282ddb31d
Cr-Commit-Position: refs/heads/master@{#425535}