[Mac] Ensure bookmark items are highlighted when invoking a context menu

[Mac] Ensure bookmark items are highlighted when invoking a context menu

Context menus run in a modal loop, so Control-clicking a bookmark item
while a contextual menu is already visible prevents animating the
item's highlight. The result was an unhighlighted bookmark item
displaying a contextual menu. This cl forces an immediate highlight of
the item so that no animation is involved.

This cl also moves code from rightMouseClicked: to the NSView methods
that are called right before and after a contextual menu appears. The
original idea of overridding rightMouseClicked: was to ensure correct
hightlighting before and after the contextual menu, but this method
is not called when you Control-click an item, only when you right
click using a mouse with a physical right mouse button.

R=avi@chromium.org
BUG=649256
Committed: https://crrev.com/f581fedebe6bc34efcaf24d2d9f45120e98e3134
Cr-Commit-Position: refs/heads/master@{#425499}

[shrike, 2016-10-14 19:12:14]

PTAL

[Avi (use Gerrit), 2016-10-14 19:34:45]

lgtm

[shrike, 2016-10-14 20:25:14]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2016-10-14 20:25:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 22:45:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-14 22:48:16]

Description was changed from

==========
[Mac] Ensure bookmark items are highlighted when invoking a context menu

Context menus run in a modal loop, so Control-clicking a bookmark item
while a contextual menu is already visible prevents animating the
item's highlight. The result was an unhighlighted bookmark item
displaying a contextual menu. This cl forces an immediate highlight of
the item so that no animation is involved.

This cl also moves code from rightMouseClicked: to the NSView methods
that are called right before and after a contextual menu appears. The
original idea of overridding rightMouseClicked: was to ensure correct
hightlighting before and after the contextual menu, but this method
is not called when you Control-click an item, only when you right
click using a mouse with a physical right mouse button.

R=avi@chromium.org
BUG=649256
==========

to

==========
[Mac] Ensure bookmark items are highlighted when invoking a context menu

Context menus run in a modal loop, so Control-clicking a bookmark item
while a contextual menu is already visible prevents animating the
item's highlight. The result was an unhighlighted bookmark item
displaying a contextual menu. This cl forces an immediate highlight of
the item so that no animation is involved.

This cl also moves code from rightMouseClicked: to the NSView methods
that are called right before and after a contextual menu appears. The
original idea of overridding rightMouseClicked: was to ensure correct
hightlighting before and after the contextual menu, but this method
is not called when you Control-click an item, only when you right
click using a mouse with a physical right mouse button.

R=avi@chromium.org
BUG=649256

Committed: https://crrev.com/f581fedebe6bc34efcaf24d2d9f45120e98e3134
Cr-Commit-Position: refs/heads/master@{#425499}
==========

[commit-bot: I haz the power, 2016-10-14 22:48:17]

Patchset 1 (id:??) landed as
https://crrev.com/f581fedebe6bc34efcaf24d2d9f45120e98e3134
Cr-Commit-Position: refs/heads/master@{#425499}