Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2418893003: Use JavaRef in JNI generator sample. (Closed)

Created:
4 years, 2 months ago by Torne
Modified:
4 years, 1 month ago
Reviewers:
rmcilroy
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use JavaRef in JNI generator sample. Switch the JNI generator sample code to use a JavaRef for java method parameters instead of jobject. BUG=506850 Committed: https://crrev.com/73656c3248e205b0d795f94cae4d99731fc1e2ef Cr-Commit-Position: refs/heads/master@{#427075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/android/jni_generator/sample_for_tests.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Torne
4 years, 2 months ago (2016-10-14 11:43:25 UTC) #2
rmcilroy
lgtm
4 years, 1 month ago (2016-10-24 14:28:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418893003/1
4 years, 1 month ago (2016-10-24 14:55:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 15:20:54 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 15:22:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73656c3248e205b0d795f94cae4d99731fc1e2ef
Cr-Commit-Position: refs/heads/master@{#427075}

Powered by Google App Engine
This is Rietveld 408576698