Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2418883002: [Remoting Android] Log app version for telemetry (Closed)

Created:
4 years, 2 months ago by Yuwei
Modified:
4 years, 2 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] Log app version for telemetry This CL makes the telemetry logger log the app version. BUG=655729 Committed: https://crrev.com/c2be2f19ba1f97e8f47c1cde42593238e8b6a37f Cr-Commit-Position: refs/heads/master@{#425142}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Sort the key #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M remoting/base/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M remoting/base/chromoting_event.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M remoting/base/chromoting_event.cc View 1 3 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Yuwei
PTAL https://codereview.chromium.org/2418883002/diff/1/remoting/base/chromoting_event.cc File remoting/base/chromoting_event.cc (left): https://codereview.chromium.org/2418883002/diff/1/remoting/base/chromoting_event.cc#oldcode85 remoting/base/chromoting_event.cc:85: std::string osName = base::SysInfo::OperatingSystemName(); osName is no longer ...
4 years, 2 months ago (2016-10-13 19:06:47 UTC) #2
Lambros
lgtm
4 years, 2 months ago (2016-10-13 19:10:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418883002/20001
4 years, 2 months ago (2016-10-13 19:10:48 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-13 20:22:33 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 20:26:04 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c2be2f19ba1f97e8f47c1cde42593238e8b6a37f
Cr-Commit-Position: refs/heads/master@{#425142}

Powered by Google App Engine
This is Rietveld 408576698