Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: src/crankshaft/hydrogen-instructions.h

Issue 2418863002: Merged: [crankshaft] Range analysis should not rely on overflowed ranges. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/crankshaft/hydrogen-instructions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_CRANKSHAFT_HYDROGEN_INSTRUCTIONS_H_ 5 #ifndef V8_CRANKSHAFT_HYDROGEN_INSTRUCTIONS_H_
6 #define V8_CRANKSHAFT_HYDROGEN_INSTRUCTIONS_H_ 6 #define V8_CRANKSHAFT_HYDROGEN_INSTRUCTIONS_H_
7 7
8 #include <cstring> 8 #include <cstring>
9 #include <iosfwd> 9 #include <iosfwd>
10 10
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 bool IsMostGeneric() const { 230 bool IsMostGeneric() const {
231 return lower_ == kMinInt && upper_ == kMaxInt && CanBeMinusZero(); 231 return lower_ == kMinInt && upper_ == kMaxInt && CanBeMinusZero();
232 } 232 }
233 bool IsInSmiRange() const { 233 bool IsInSmiRange() const {
234 return lower_ >= Smi::kMinValue && upper_ <= Smi::kMaxValue; 234 return lower_ >= Smi::kMinValue && upper_ <= Smi::kMaxValue;
235 } 235 }
236 void ClampToSmi() { 236 void ClampToSmi() {
237 lower_ = Max(lower_, Smi::kMinValue); 237 lower_ = Max(lower_, Smi::kMinValue);
238 upper_ = Min(upper_, Smi::kMaxValue); 238 upper_ = Min(upper_, Smi::kMaxValue);
239 } 239 }
240 void Clear();
240 void KeepOrder(); 241 void KeepOrder();
241 #ifdef DEBUG 242 #ifdef DEBUG
242 void Verify() const; 243 void Verify() const;
243 #endif 244 #endif
244 245
245 void StackUpon(Range* other) { 246 void StackUpon(Range* other) {
246 Intersect(other); 247 Intersect(other);
247 next_ = other; 248 next_ = other;
248 } 249 }
249 250
(...skipping 6787 matching lines...) Expand 10 before | Expand all | Expand 10 after
7037 bool IsDeletable() const override { return true; } 7038 bool IsDeletable() const override { return true; }
7038 }; 7039 };
7039 7040
7040 #undef DECLARE_INSTRUCTION 7041 #undef DECLARE_INSTRUCTION
7041 #undef DECLARE_CONCRETE_INSTRUCTION 7042 #undef DECLARE_CONCRETE_INSTRUCTION
7042 7043
7043 } // namespace internal 7044 } // namespace internal
7044 } // namespace v8 7045 } // namespace v8
7045 7046
7046 #endif // V8_CRANKSHAFT_HYDROGEN_INSTRUCTIONS_H_ 7047 #endif // V8_CRANKSHAFT_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « no previous file | src/crankshaft/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698