chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java - Issue 2418843002: Correctly rename minidumps "foo.dmpX.try0" after failed uploads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

Issue 2418843002: Correctly rename minidumps "foo.dmpX.try0" after failed uploads. (Closed)

Patch Set: Added some tests to ensure CrashFileManager.readAttemptNumber returns -1 in cases like ".try-X" (e.… Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

index 4c3ededdecd09cd9887d65479cfe573e8f3f72aa..613a3a456c263c3d1b947ac05d5d325f6ca9248b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

@@ -222,6 +222,10 @@ public class MinidumpUploadService extends IntentService {

return;

}

int tries = CrashFileManager.readAttemptNumber(minidumpFileName);

+ // -1 means no attempt number was read.

+ if (tries == -1) {

+ tries = 0;

+ }

// Since we do not rename a file after reaching max number of tries,

// files that have maxed out tries will NOT reach this.