[Reland] Refactoring of SBER preference usage

chrome/browser/ui/views/download/download_feedback_dialog_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/download/download_feedback_dialog_view.h"
 
 #include "base/metrics/histogram_macros.h"
 #include "base/supports_user_data.h"
 #include "chrome/browser/platform_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/constrained_window/constrained_window_views.h"
 #include "components/prefs/pref_service.h"
+#include "components/safe_browsing_db/safe_browsing_prefs.h"
 #include "components/strings/grit/components_strings.h"
 #include "content/public/browser/page_navigator.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/views/controls/link.h"
 #include "ui/views/controls/message_box_view.h"
 #include "ui/views/widget/widget.h"
 
 using content::OpenURLParams;
 
 namespace {
@@ skipping 13 matching lines @@
 }  // namespace
 
 // static
 void DownloadFeedbackDialogView::Show(
     gfx::NativeWindow parent_window,
     Profile* profile,
     content::PageNavigator* navigator,
     const UserDecisionCallback& callback) {
   // This dialog should only be shown if it hasn't been shown before.
   DCHECK(!profile->GetPrefs()->HasPrefPath(
-      prefs::kSafeBrowsingExtendedReportingEnabled));
+      safe_browsing::GetExtendedReportingPrefName()));
 
   // Only one dialog should be shown at a time, so check to see if another one
   // is open. If another one is open, treat this parallel call as if reporting
   // is disabled (to be conservative).
   DialogStatusData* data =
       static_cast<DialogStatusData*>(profile->GetUserData(kDialogStatusKey));
   if (data == NULL) {
     data = new DialogStatusData();
     profile->SetUserData(kDialogStatusKey, data);
   }
@@ skipping 34 matching lines @@
   return ui::DIALOG_BUTTON_CANCEL;
 }
 
 base::string16 DownloadFeedbackDialogView::GetDialogButtonLabel(
     ui::DialogButton button) const {
   return (button == ui::DIALOG_BUTTON_OK) ?
       ok_button_text_ : cancel_button_text_;
 }
 
 bool DownloadFeedbackDialogView::OnButtonClicked(bool accepted) {
-  profile_->GetPrefs()->SetBoolean(prefs::kSafeBrowsingExtendedReportingEnabled,
-                                   accepted);
+  profile_->GetPrefs()->SetBoolean(
+      safe_browsing::GetExtendedReportingPrefName(), accepted);
   DialogStatusData* data =
      static_cast<DialogStatusData*>(profile_->GetUserData(kDialogStatusKey));
   DCHECK(data);
   data->set_currently_shown(false);
 
   UMA_HISTOGRAM_BOOLEAN("Download.FeedbackDialogEnabled", accepted);
 
   callback_.Run(accepted);
   return true;
 }
@@ skipping 39 matching lines @@
   WindowOpenDisposition disposition =
       ui::DispositionFromEventFlags(event_flags);
   content::OpenURLParams params(
       GURL(l10n_util::GetStringUTF8(IDS_SAFE_BROWSING_PRIVACY_POLICY_URL)),
       content::Referrer(), disposition == WindowOpenDisposition::CURRENT_TAB
                                ? WindowOpenDisposition::NEW_FOREGROUND_TAB
                                : disposition,
       ui::PAGE_TRANSITION_LINK, false);
   navigator_->OpenURL(params);
 }