[Reland] Refactoring of SBER preference usage

chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <list>
 
 #include "base/run_loop.h"
 #include "chrome/browser/interstitials/chrome_controller_client.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/safe_browsing/safe_browsing_blocking_page.h"
 #include "chrome/browser/safe_browsing/test_safe_browsing_service.h"
 #include "chrome/browser/safe_browsing/threat_details.h"
 #include "chrome/browser/safe_browsing/ui_manager.h"
-#include "chrome/common/pref_names.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "components/prefs/pref_service.h"
+#include "components/safe_browsing_db/safe_browsing_prefs.h"
 #include "content/public/browser/interstitial_page.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/web_contents_tester.h"
 
 using content::InterstitialPage;
 using content::NavigationEntry;
 using content::WebContents;
 using content::WebContentsTester;
@@ skipping 201 matching lines @@
   UserResponse user_response_;
   TestSafeBrowsingBlockingPageFactory factory_;
 };
 
 
 // Tests showing a blocking page for a malware page and not proceeding.
 TEST_F(SafeBrowsingBlockingPageTest, MalwarePageDontProceed) {
   // Enable malware details.
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled, true);
+  profile->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(), true);
 
   // Start a load.
   controller().LoadURL(GURL(kBadURL), content::Referrer(),
                        ui::PAGE_TRANSITION_TYPED, std::string());
 
 
   // Simulate the load causing a safe browsing interstitial to be shown.
   ShowInterstitial(false, kBadURL);
   SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
   ASSERT_TRUE(sb_interstitial);
@@ skipping 13 matching lines @@
   // A report should have been sent.
   EXPECT_EQ(1u, ui_manager_->GetThreatDetails()->size());
   ui_manager_->GetThreatDetails()->clear();
 }
 
 // Tests showing a blocking page for a malware page and then proceeding.
 TEST_F(SafeBrowsingBlockingPageTest, MalwarePageProceed) {
   // Enable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled, true);
+  profile->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(), true);
 
   // Start a load.
   controller().LoadURL(GURL(kBadURL), content::Referrer(),
                        ui::PAGE_TRANSITION_TYPED, std::string());
   int pending_id = controller().GetPendingEntry()->GetUniqueID();
 
   // Simulate the load causing a safe browsing interstitial to be shown.
   ShowInterstitial(false, kBadURL);
   SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
   ASSERT_TRUE(sb_interstitial);
@@ skipping 12 matching lines @@
   EXPECT_EQ(1u, ui_manager_->GetThreatDetails()->size());
   ui_manager_->GetThreatDetails()->clear();
 }
 
 // Tests showing a blocking page for a page that contains malware subresources
 // and not proceeding.
 TEST_F(SafeBrowsingBlockingPageTest, PageWithMalwareResourceDontProceed) {
   // Enable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled, true);
+  profile->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(), true);
 
   // Navigate somewhere.
   Navigate(kGoogleURL, 1, 0, true);
 
   // Navigate somewhere else.
   Navigate(kGoodURL, 2, 0, true);
 
   // Simulate that page loading a bad-resource triggering an interstitial.
   ShowInterstitial(true, kBadURL);
 
@@ skipping 14 matching lines @@
   EXPECT_EQ(1u, ui_manager_->GetThreatDetails()->size());
   ui_manager_->GetThreatDetails()->clear();
 }
 
 // Tests showing a blocking page for a page that contains malware subresources
 // and proceeding.
 TEST_F(SafeBrowsingBlockingPageTest, PageWithMalwareResourceProceed) {
   // Enable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled, true);
+  profile->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(), true);
 
   // Navigate somewhere.
   Navigate(kGoodURL, 1, 0, true);
 
   // Simulate that page loading a bad-resource triggering an interstitial.
   ShowInterstitial(true, kBadURL);
 
   SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
   ASSERT_TRUE(sb_interstitial);
 
@@ skipping 12 matching lines @@
 }
 
 // Tests showing a blocking page for a page that contains multiple malware
 // subresources and not proceeding.  This just tests that the extra malware
 // subresources (which trigger queued interstitial pages) do not break anything.
 TEST_F(SafeBrowsingBlockingPageTest,
        PageWithMultipleMalwareResourceDontProceed) {
   // Enable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled, true);
+  profile->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(), true);
 
   // Navigate somewhere.
   Navigate(kGoogleURL, 1, 0, true);
 
   // Navigate somewhere else.
   Navigate(kGoodURL, 2, 0, true);
 
   // Simulate that page loading a bad-resource triggering an interstitial.
   ShowInterstitial(true, kBadURL);
 
@@ skipping 20 matching lines @@
   ui_manager_->GetThreatDetails()->clear();
 }
 
 // Tests showing a blocking page for a page that contains multiple malware
 // subresources and proceeding through the first interstitial, but not the next.
 TEST_F(SafeBrowsingBlockingPageTest,
        PageWithMultipleMalwareResourceProceedThenDontProceed) {
   // Enable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled, true);
+  profile->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(), true);
 
   // Navigate somewhere.
   Navigate(kGoogleURL, 1, 0, true);
 
   // Navigate somewhere else.
   Navigate(kGoodURL, 2, 0, true);
 
   // Simulate that page loading a bad-resource triggering an interstitial.
   ShowInterstitial(true, kBadURL);
 
@@ skipping 35 matching lines @@
   EXPECT_EQ(0u, ui_manager_->GetThreatDetails()->size());
   ui_manager_->GetThreatDetails()->clear();
 }
 
 // Tests showing a blocking page for a page that contains multiple malware
 // subresources and proceeding through the multiple interstitials.
 TEST_F(SafeBrowsingBlockingPageTest, PageWithMultipleMalwareResourceProceed) {
   // Enable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled, true);
+  profile->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(), true);
 
   // Navigate somewhere else.
   Navigate(kGoodURL, 1, 0, true);
 
   // Simulate that page loading a bad-resource triggering an interstitial.
   ShowInterstitial(true, kBadURL);
 
   // More bad resources loading causing more interstitials. The new
   // interstitials should be queued.
   ShowInterstitial(true, kBadURL2);
@@ skipping 30 matching lines @@
   EXPECT_EQ(0u, ui_manager_->GetThreatDetails()->size());
   ui_manager_->GetThreatDetails()->clear();
 }
 
 // Tests showing a blocking page then navigating back and forth to make sure the
 // controller entries are OK.  http://crbug.com/17627
 TEST_F(SafeBrowsingBlockingPageTest, NavigatingBackAndForth) {
   // Enable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled, true);
+  profile->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(), true);
 
   // Navigate somewhere.
   Navigate(kGoodURL, 1, 0, true);
 
   // Now navigate to a bad page triggerring an interstitial.
   controller().LoadURL(GURL(kBadURL), content::Referrer(),
                        ui::PAGE_TRANSITION_TYPED, std::string());
   int pending_id = controller().GetPendingEntry()->GetUniqueID();
   ShowInterstitial(false, kBadURL);
   SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
@@ skipping 30 matching lines @@
   EXPECT_EQ(2u, ui_manager_->GetThreatDetails()->size());
   ui_manager_->GetThreatDetails()->clear();
 }
 
 // Tests that calling "don't proceed" after "proceed" has been called doesn't
 // cause problems. http://crbug.com/30079
 TEST_F(SafeBrowsingBlockingPageTest, ProceedThenDontProceed) {
   // Enable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled, true);
+  profile->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(), true);
 
   // Start a load.
   controller().LoadURL(GURL(kBadURL), content::Referrer(),
                        ui::PAGE_TRANSITION_TYPED, std::string());
 
   // Simulate the load causing a safe browsing interstitial to be shown.
   ShowInterstitial(false, kBadURL);
   SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
   ASSERT_TRUE(sb_interstitial);
 
@@ skipping 14 matching lines @@
   // Only one report should have been sent.
   EXPECT_EQ(1u, ui_manager_->GetThreatDetails()->size());
   ui_manager_->GetThreatDetails()->clear();
 }
 
 // Tests showing a blocking page for a malware page with reports disabled.
 TEST_F(SafeBrowsingBlockingPageTest, MalwareReportsDisabled) {
   // Disable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled, false);
+  profile->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(), false);
 
   // Start a load.
   controller().LoadURL(GURL(kBadURL), content::Referrer(),
                        ui::PAGE_TRANSITION_TYPED, std::string());
 
   // Simulate the load causing a safe browsing interstitial to be shown.
   ShowInterstitial(false, kBadURL);
   SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
   ASSERT_TRUE(sb_interstitial);
   EXPECT_TRUE(sb_interstitial->CanShowThreatDetailsOption());
@@ skipping 13 matching lines @@
   // No report should have been sent.
   EXPECT_EQ(0u, ui_manager_->GetThreatDetails()->size());
   ui_manager_->GetThreatDetails()->clear();
 }
 
 // Test that toggling the checkbox has the anticipated effects.
 TEST_F(SafeBrowsingBlockingPageTest, MalwareReportsToggling) {
   // Disable malware reports.
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled, false);
+  profile->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(), false);
 
   // Start a load.
   controller().LoadURL(GURL(kBadURL), content::Referrer(),
                        ui::PAGE_TRANSITION_TYPED, std::string());
 
   // Simulate the load causing a safe browsing interstitial to be shown.
   ShowInterstitial(false, kBadURL);
   SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
   ASSERT_TRUE(sb_interstitial);
   EXPECT_TRUE(sb_interstitial->CanShowThreatDetailsOption());
 
   base::RunLoop().RunUntilIdle();
 
-  EXPECT_FALSE(profile->GetPrefs()->GetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled));
+  EXPECT_FALSE(IsExtendedReportingEnabled(*profile->GetPrefs()));
 
   // Simulate the user check the report agreement checkbox.
   sb_interstitial->controller()->SetReportingPreference(true);
 
-  EXPECT_TRUE(profile->GetPrefs()->GetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled));
+  EXPECT_TRUE(IsExtendedReportingEnabled(*profile->GetPrefs()));
 
   // Simulate the user uncheck the report agreement checkbox.
   sb_interstitial->controller()->SetReportingPreference(false);
 
-  EXPECT_FALSE(profile->GetPrefs()->GetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled));
+  EXPECT_FALSE(IsExtendedReportingEnabled(*profile->GetPrefs()));
 }
 
 // Test that extended reporting option is not shown on blocking an HTTPS main
 // page, and no report is sent.
 TEST_F(SafeBrowsingBlockingPageTest, ExtendedReportingNotShownOnSecurePage) {
   // Enable malware details.
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled, true);
+  profile->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(), true);
 
   // Start a load.
   controller().LoadURL(GURL(kBadHTTPSURL), content::Referrer(),
                        ui::PAGE_TRANSITION_TYPED, std::string());
 
   // Simulate the load causing a safe browsing interstitial to be shown.
   ShowInterstitial(false, kBadHTTPSURL);
   SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
   ASSERT_TRUE(sb_interstitial);
   EXPECT_FALSE(sb_interstitial->CanShowThreatDetailsOption());
@@ skipping 12 matching lines @@
   ui_manager_->GetThreatDetails()->clear();
 }
 
 // Test that extended reporting option is not shown on blocking an HTTPS
 // subresource on an HTTPS page, and no report is sent.
 TEST_F(SafeBrowsingBlockingPageTest,
        ExtendedReportingNotShownOnSecurePageWithSecureSubresource) {
   // Enable malware details.
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled, true);
+  profile->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(), true);
 
   // Commit a load.
   content::WebContentsTester::For(web_contents())
         ->NavigateAndCommit(GURL(kGoodHTTPSURL));
 
   // Simulate a subresource load causing a safe browsing interstitial to be
   // shown.
   ShowInterstitial(true, kBadHTTPSURL);
   SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
   ASSERT_TRUE(sb_interstitial);
@@ skipping 13 matching lines @@
   ui_manager_->GetThreatDetails()->clear();
 }
 
 // Test that extended reporting option is not shown on blocking an HTTP
 // subresource on an HTTPS page, and no report is sent.
 TEST_F(SafeBrowsingBlockingPageTest,
        ExtendedReportingNotShownOnSecurePageWithInsecureSubresource) {
   // Enable malware details.
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled, true);
+  profile->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(), true);
 
   // Commit a load.
   content::WebContentsTester::For(web_contents())
         ->NavigateAndCommit(GURL(kGoodHTTPSURL));
 
   // Simulate a subresource load causing a safe browsing interstitial to be
   // shown.
   ShowInterstitial(true, kBadURL);
   SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
   ASSERT_TRUE(sb_interstitial);
@@ skipping 13 matching lines @@
   ui_manager_->GetThreatDetails()->clear();
 }
 
 // Test that extended reporting option is shown on blocking an HTTPS
 // subresource on an HTTP page.
 TEST_F(SafeBrowsingBlockingPageTest,
        ExtendedReportingOnInsecurePageWithSecureSubresource) {
   // Enable malware details.
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled, true);
+  profile->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(), true);
 
   // Commit a load.
   content::WebContentsTester::For(web_contents())
         ->NavigateAndCommit(GURL(kGoodURL));
 
   // Simulate a subresource load causing a safe browsing interstitial to be
   // shown.
   ShowInterstitial(true, kBadHTTPSURL);
   SafeBrowsingBlockingPage* sb_interstitial = GetSafeBrowsingBlockingPage();
   ASSERT_TRUE(sb_interstitial);
@@ skipping 14 matching lines @@
 }
 
 // Test that extended reporting option is not shown on blocking an HTTPS
 // subresource on an HTTPS page while there is a pending load for an HTTP page,
 // and no report is sent.
 TEST_F(SafeBrowsingBlockingPageTest,
        ExtendedReportingNotShownOnSecurePageWithPendingInsecureLoad) {
   // Enable malware details.
   Profile* profile = Profile::FromBrowserContext(
       web_contents()->GetBrowserContext());
-  profile->GetPrefs()->SetBoolean(
-      prefs::kSafeBrowsingExtendedReportingEnabled, true);
+  profile->GetPrefs()->SetBoolean(GetExtendedReportingPrefName(), true);
 
   // Commit a load.
   content::WebContentsTester::For(web_contents())
         ->NavigateAndCommit(GURL(kGoodHTTPSURL));
 
   GURL pending_url("http://slow.example.com");
 
   // Start a pending load.
   content::WebContentsTester::For(web_contents())->StartNavigation(pending_url);
 
@@ skipping 17 matching lines @@
 
   // No report should have been sent.
   EXPECT_EQ(0u, ui_manager_->GetThreatDetails()->size());
   ui_manager_->GetThreatDetails()->clear();
 }
 
 // TODO(mattm): Add test for extended reporting not shown or sent in incognito
 // window.
 
 }  // namespace safe_browsing