Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 2418803003: [heap] Consider both marking deques when triggering a GC in finalization (Closed)

Created:
4 years, 2 months ago by Michael Lippautz
Modified:
4 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Consider both marking deques when triggering a GC in finalization R=ulan@chromium.org BUG=chromium:468240 Committed: https://crrev.com/0ee8eea2f4066e688d5f6ac2e2fc7ebcf8b5638f Cr-Commit-Position: refs/heads/master@{#40284}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Michael Lippautz
4 years, 2 months ago (2016-10-13 14:53:41 UTC) #2
Michael Lippautz
4 years, 2 months ago (2016-10-13 14:53:42 UTC) #3
ulan
lgtm
4 years, 2 months ago (2016-10-13 14:55:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418803003/1
4 years, 2 months ago (2016-10-13 17:23:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 17:48:44 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 17:49:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ee8eea2f4066e688d5f6ac2e2fc7ebcf8b5638f
Cr-Commit-Position: refs/heads/master@{#40284}

Powered by Google App Engine
This is Rietveld 408576698