Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2418803002: [turbofan]: Micro optimizations to lea[l/q] on ia32/x64 (Closed)

Created:
4 years, 2 months ago by danno
Modified:
4 years, 2 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan]: Micro optimizations to lea[l/q] on ia32/x64 Utilize all opportunities to turn leas into adds. Committed: https://crrev.com/87ae05c7c418bee367a2006f0658a3dd171ed619 Cr-Commit-Position: refs/heads/master@{#40341}

Patch Set 1 #

Patch Set 2 : Updates #

Patch Set 3 : Fix syntax error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +39 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
danno
Some missing stuff that occurred to me while looking at the code related the lea ...
4 years, 2 months ago (2016-10-13 20:55:32 UTC) #14
titzer
lgtm
4 years, 2 months ago (2016-10-15 12:14:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418803002/40001
4 years, 2 months ago (2016-10-17 08:11:43 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-17 08:57:04 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 08:57:55 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/87ae05c7c418bee367a2006f0658a3dd171ed619
Cr-Commit-Position: refs/heads/master@{#40341}

Powered by Google App Engine
This is Rietveld 408576698