Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2418773002: [heap] Move slot filtering logic into sweeper. (Closed)

Created:
4 years, 2 months ago by Hannes Payer (out of office)
Modified:
4 years, 2 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Move slot filtering logic into sweeper. BUG=chromium:648568 Committed: https://crrev.com/18db69c38c93450c1ae957999fc48c465f111f00 Cr-Commit-Position: refs/heads/master@{#40267}

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : unittest mode #

Patch Set 4 : remove prefree mode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -65 lines) Patch
M src/heap/mark-compact.cc View 6 chunks +20 lines, -8 lines 0 comments Download
M src/heap/remembered-set.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/remembered-set.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M src/heap/slot-set.h View 1 2 3 4 chunks +32 lines, -17 lines 0 comments Download
M test/unittests/heap/slot-set-unittest.cc View 1 2 2 chunks +22 lines, -16 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
Hannes Payer (out of office)
4 years, 2 months ago (2016-10-13 10:40:24 UTC) #4
Michael Lippautz
Is it possible to write a unittest for RemoveRange for both values of EmptyBucketMode?
4 years, 2 months ago (2016-10-13 10:46:41 UTC) #7
Hannes Payer (out of office)
Done.
4 years, 2 months ago (2016-10-13 12:39:43 UTC) #12
ulan
lgtm
4 years, 2 months ago (2016-10-13 12:51:10 UTC) #13
Michael Lippautz
lgtm
4 years, 2 months ago (2016-10-13 12:51:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418773002/60001
4 years, 2 months ago (2016-10-13 12:58:34 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-13 13:43:09 UTC) #18
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/18db69c38c93450c1ae957999fc48c465f111f00 Cr-Commit-Position: refs/heads/master@{#40267}
4 years, 2 months ago (2016-10-13 13:43:27 UTC) #20
Michael Achenbach
4 years, 2 months ago (2016-10-14 06:58:49 UTC) #21

Powered by Google App Engine
This is Rietveld 408576698