Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2418763006: Add f16c (halffloat) cpuid (Closed)

Created:
4 years, 2 months ago by fbarchard1
Modified:
4 years, 2 months ago
Reviewers:
wengchang, wangcheng, hubbe
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : F16C in cpuid app #

Patch Set 3 : F16C in cpuid app #

Patch Set 4 : add LIBYUV_DISABLE_F16C enviroment variable #

Patch Set 5 : bump version to r1627 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M README.chromium View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/cpu_id.h View 1 chunk +4 lines, -2 lines 0 comments Download
M include/libyuv/version.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M source/cpu_id.cc View 1 2 3 2 chunks +11 lines, -5 lines 0 comments Download
M source/planar_functions.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M unit_test/cpu_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M util/cpuid.c View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
fbarchard1
4 years, 2 months ago (2016-10-14 18:53:40 UTC) #1
fbarchard1
Ivybridge has AVX and F16C but not AVX2: out/Release/cpuid Cpu Vendor: GenuineIntel Cpu Family 6 ...
4 years, 2 months ago (2016-10-14 22:01:09 UTC) #2
fbarchard1
Some documentation on cpuid for F16C: https://en.wikipedia.org/wiki/CPUID
4 years, 2 months ago (2016-10-14 22:17:08 UTC) #6
fbarchard1
LIBYUV_DISABLE_F16C=1 out/Release/cpuid Cpu Vendor: GenuineIntel Cpu Family 6 (0x6), Model 62 (0x3e) Cpu Flags bf1 ...
4 years, 2 months ago (2016-10-14 22:26:20 UTC) #7
fbarchard1
On Macbook Air w/ broadwell SSE2 TestHalfFloatPlane (474 ms) F16C TestHalfFloatPlane (394 ms) C vectorized ...
4 years, 2 months ago (2016-10-14 22:31:04 UTC) #8
fbarchard1
For now, adding F16C detect is proper thing to test for, but this HalfFloat conversion ...
4 years, 2 months ago (2016-10-14 22:52:34 UTC) #10
wangcheng
lgtm
4 years, 2 months ago (2016-10-14 23:15:03 UTC) #12
fbarchard1
4 years, 2 months ago (2016-10-14 23:34:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
fdcf524aacb38b1e476f82abe5dc2e7dbf07dbc7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698