Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2418763003: Invoke CanSuspendBackgroundedRenderer in TabManager::PurgeAndSuspendBackgroundedTabs. (Closed)

Created:
4 years, 2 months ago by tasak
Modified:
4 years, 2 months ago
Reviewers:
haraken, chrisha
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Invoke CanSuspendBackgroundedRenderer in TabManager::PurgeAndSuspendBackgroundedTabs. - intent-to-implement-and-ship of background renderer's purge + suspend is https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DK189tnM8l4 - one of the documents attached in the above intent is https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJvI/edit?usp=sharing - The feature is not enabled by default because purge-and-suspend-time is 0. BUG=635419 Committed: https://crrev.com/c69e250806f8b33ef6375f557911a52e1542e178 Cr-Commit-Position: refs/heads/master@{#425623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/memory/tab_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
tasak
Would you review this CL?
4 years, 2 months ago (2016-10-14 07:36:30 UTC) #4
haraken
LGTM
4 years, 2 months ago (2016-10-14 10:39:27 UTC) #7
chrisha
lgtm!
4 years, 2 months ago (2016-10-14 19:54:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418763003/1
4 years, 2 months ago (2016-10-17 04:26:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 06:09:13 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 06:10:43 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c69e250806f8b33ef6375f557911a52e1542e178
Cr-Commit-Position: refs/heads/master@{#425623}

Powered by Google App Engine
This is Rietveld 408576698