[heap] Fix MemoryAllocator::AllocateAlignedMemory.

[heap] Fix MemoryAllocator::AllocateAlignedMemory.

AllocateAlignedMemory calls ReserveAlignedMemory which increments size_
value. In some cases AllocateAlignedMemory can return NULL value. Before
returning NULL, AllocateAlignedMemory should decrease size_ value.

TEST=cctest/test-spaces/LargeObjectSpace
BUG=

Committed: https://crrev.com/9cb42010aa9434df893f8bf9473a380ba51e38c2
Cr-Commit-Position: refs/heads/master@{#40262}

[Ilija.Pavlovic1, 2016-10-13 07:48:52]

ilija.pavlovic@imgtec.com changed reviewers:
+ hpayer@chromium.org, ivica.bogosavljevic@imgtec.com, jochen@chromium.org,
marija.antic@imgtec.com, miran.karic@imgtec.com, mlippautz@chromium.org,
mstarzinger@chromium.org, ulan@chromium.org

[Ilija.Pavlovic1, 2016-10-13 07:48:53]

PTAL.

[Michael Lippautz, 2016-10-13 08:24:36]

https://codereview.chromium.org/2418733002/diff/1/src/heap/spaces.cc
File src/heap/spaces.cc (right):

https://codereview.chromium.org/2418733002/diff/1/src/heap/spaces.cc#newcode463
src/heap/spaces.cc:463: size_.Decrement(reserve_size);
IIUC ReserveAlignedMemory only increments if it succeeds, so this Decrement
should not be necessary.

[Ilija.Pavlovic1, 2016-10-13 12:29:58]

https://codereview.chromium.org/2418733002/diff/1/src/heap/spaces.cc
File src/heap/spaces.cc (right):

https://codereview.chromium.org/2418733002/diff/1/src/heap/spaces.cc#newcode463
src/heap/spaces.cc:463: size_.Decrement(reserve_size);
On 2016/10/13 08:24:36, Michael Lippautz wrote:
> IIUC ReserveAlignedMemory only increments if it succeeds, so this Decrement
> should not be necessary.

This Decrement will be removed.

Done.

[Michael Lippautz, 2016-10-13 12:40:08]

On 2016/10/13 12:29:58, Ilija.Pavlovic1 wrote:
> https://codereview.chromium.org/2418733002/diff/1/src/heap/spaces.cc
> File src/heap/spaces.cc (right):
> 
>
https://codereview.chromium.org/2418733002/diff/1/src/heap/spaces.cc#newcode463
> src/heap/spaces.cc:463: size_.Decrement(reserve_size);
> On 2016/10/13 08:24:36, Michael Lippautz wrote:
> > IIUC ReserveAlignedMemory only increments if it succeeds, so this Decrement
> > should not be necessary.
> 
> This Decrement will be removed.
> 
> Done.

lgtm, thanks!

[Ilija.Pavlovic1, 2016-10-13 12:41:32]

The CQ bit was checked by ilija.pavlovic@imgtec.com

[commit-bot: I haz the power, 2016-10-13 12:41:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 13:10:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-13 13:10:49]

Description was changed from

==========
[heap] Fix MemoryAllocator::AllocateAlignedMemory.

AllocateAlignedMemory calls ReserveAlignedMemory which increments size_
value. In some cases AllocateAlignedMemory can return NULL value. Before
returning NULL, AllocateAlignedMemory should decrease size_ value.

TEST=cctest/test-spaces/LargeObjectSpace
BUG=
==========

to

==========
[heap] Fix MemoryAllocator::AllocateAlignedMemory.

AllocateAlignedMemory calls ReserveAlignedMemory which increments size_
value. In some cases AllocateAlignedMemory can return NULL value. Before
returning NULL, AllocateAlignedMemory should decrease size_ value.

TEST=cctest/test-spaces/LargeObjectSpace
BUG=

Committed: https://crrev.com/9cb42010aa9434df893f8bf9473a380ba51e38c2
Cr-Commit-Position: refs/heads/master@{#40262}
==========

[commit-bot: I haz the power, 2016-10-13 13:10:50]

Patchset 2 (id:??) landed as
https://crrev.com/9cb42010aa9434df893f8bf9473a380ba51e38c2
Cr-Commit-Position: refs/heads/master@{#40262}