[mac] Fixed FramedBrowserWindowTest.WindowWidgetLocation.

[mac] Fixed FramedBrowserWindowTest.WindowWidgetLocation.

- call [window_ layoutIfNeeded] to update buttons position, which
   is controlled by layout constraints
- use window coordinates for verifying button locations

BUG=655112, 605219
TBR=tapted@chromium.org

Committed: https://crrev.com/0bd2a26b4420c4d4abb0f1101111e16c8f65c91c
Cr-Commit-Position: refs/heads/master@{#425211}

[Eugene But (OOO till 7-30), 2016-10-13 04:20:26]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 04:20:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 04:54:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 04:54:39]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Eugene But (OOO till 7-30), 2016-10-13 05:20:06]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 05:20:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 05:45:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 05:45:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Eugene But (OOO till 7-30), 2016-10-13 06:05:57]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 06:06:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 06:15:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 06:15:03]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Eugene But (OOO till 7-30), 2016-10-13 06:24:10]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 06:24:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 06:32:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 06:32:45]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Eugene But (OOO till 7-30), 2016-10-13 07:00:02]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 07:00:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 07:34:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 07:34:05]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Eugene But (OOO till 7-30), 2016-10-13 07:35:17]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 07:35:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2016-10-13 08:07:41]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 08:07:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 08:23:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 08:23:22]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2016-10-13 21:55:58]

Description was changed from

==========
[mac] Fixed FramedBrowserWindowTest.WindowWidgetLocation.

BUG=655112
==========

to

==========
[mac] Fixed FramedBrowserWindowTest.WindowWidgetLocation.

- call [window_ layoutIfNeeded] to update buttons position, which
   is controlled by layout constraints
- use window coordinates for verifying button locations

BUG=655112
==========

[Eugene But (OOO till 7-30), 2016-10-13 21:56:11]

eugenebut@chromium.org changed reviewers:
+ erikchen@chromium.org, tapted@chromium.org

[erikchen, 2016-10-13 21:57:54]

https://codereview.chromium.org/2418703002/diff/180001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/framed_browser_window_unittest.mm (right):

https://codereview.chromium.org/2418703002/diff/180001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/framed_browser_window_unittest.mm:115: [window_
layoutIfNeeded];
Why is this necessary? Is it because when I present a window [which isn't done
here], it automatically updates the layout?

[Eugene But (OOO till 7-30), 2016-10-13 21:57:55]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 21:58:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2016-10-13 22:03:27]

https://codereview.chromium.org/2418703002/diff/180001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/framed_browser_window_unittest.mm (right):

https://codereview.chromium.org/2418703002/diff/180001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/framed_browser_window_unittest.mm:115: [window_
layoutIfNeeded];
On 2016/10/13 21:57:54, erikchen wrote:
> Why is this necessary? Is it because when I present a window [which isn't done
> here], it automatically updates the layout?
Yes, layout constraints are not kicked in otherwise. Presenting window calls
layoutIfNeeded.

Added comments before the call.

[Eugene But (OOO till 7-30), 2016-10-13 22:07:34]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 22:08:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 22:40:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 22:40:54]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-10-13 23:24:57]

lgtm

[Eugene But (OOO till 7-30), 2016-10-14 00:01:41]

Description was changed from

==========
[mac] Fixed FramedBrowserWindowTest.WindowWidgetLocation.

- call [window_ layoutIfNeeded] to update buttons position, which
   is controlled by layout constraints
- use window coordinates for verifying button locations

BUG=655112
==========

to

==========
[mac] Fixed FramedBrowserWindowTest.WindowWidgetLocation.

- call [window_ layoutIfNeeded] to update buttons position, which
   is controlled by layout constraints
- use window coordinates for verifying button locations

BUG=655112
TBR=tapted@chromium.org
==========

[Eugene But (OOO till 7-30), 2016-10-14 00:01:59]

Thanks for quick review!

[Eugene But (OOO till 7-30), 2016-10-14 00:02:05]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-10-14 00:02:29]

Description was changed from

==========
[mac] Fixed FramedBrowserWindowTest.WindowWidgetLocation.

- call [window_ layoutIfNeeded] to update buttons position, which
   is controlled by layout constraints
- use window coordinates for verifying button locations

BUG=655112
TBR=tapted@chromium.org
==========

to

==========
[mac] Fixed FramedBrowserWindowTest.WindowWidgetLocation.

- call [window_ layoutIfNeeded] to update buttons position, which
   is controlled by layout constraints
- use window coordinates for verifying button locations

BUG=655112, 605219
TBR=tapted@chromium.org
==========

[Eugene But (OOO till 7-30), 2016-10-14 00:02:35]

The CQ bit was unchecked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-10-14 00:02:40]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2016-10-14 00:02:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 00:11:20]

Description was changed from

==========
[mac] Fixed FramedBrowserWindowTest.WindowWidgetLocation.

- call [window_ layoutIfNeeded] to update buttons position, which
   is controlled by layout constraints
- use window coordinates for verifying button locations

BUG=655112, 605219
TBR=tapted@chromium.org
==========

to

==========
[mac] Fixed FramedBrowserWindowTest.WindowWidgetLocation.

- call [window_ layoutIfNeeded] to update buttons position, which
   is controlled by layout constraints
- use window coordinates for verifying button locations

BUG=655112, 605219
TBR=tapted@chromium.org
==========

[commit-bot: I haz the power, 2016-10-14 00:11:21]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-10-14 00:13:51]

Description was changed from

==========
[mac] Fixed FramedBrowserWindowTest.WindowWidgetLocation.

- call [window_ layoutIfNeeded] to update buttons position, which
   is controlled by layout constraints
- use window coordinates for verifying button locations

BUG=655112, 605219
TBR=tapted@chromium.org
==========

to

==========
[mac] Fixed FramedBrowserWindowTest.WindowWidgetLocation.

- call [window_ layoutIfNeeded] to update buttons position, which
   is controlled by layout constraints
- use window coordinates for verifying button locations

BUG=655112, 605219
TBR=tapted@chromium.org

Committed: https://crrev.com/0bd2a26b4420c4d4abb0f1101111e16c8f65c91c
Cr-Commit-Position: refs/heads/master@{#425211}
==========

[commit-bot: I haz the power, 2016-10-14 00:13:53]

Patchset 11 (id:??) landed as
https://crrev.com/0bd2a26b4420c4d4abb0f1101111e16c8f65c91c
Cr-Commit-Position: refs/heads/master@{#425211}