Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: runtime/vm/stub_code_arm.cc

Issue 2418673002: Fix unoptimized code calling a disabled code when --verify-on-transition is enabled. (Closed)
Patch Set: dbc Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/simulator_dbc.cc ('k') | runtime/vm/stub_code_arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 1878 matching lines...) Expand 10 before | Expand all | Expand 10 after
1889 // R8: function to be reoptimized. 1889 // R8: function to be reoptimized.
1890 // R4: argument descriptor (preserved). 1890 // R4: argument descriptor (preserved).
1891 void StubCode::GenerateOptimizeFunctionStub(Assembler* assembler) { 1891 void StubCode::GenerateOptimizeFunctionStub(Assembler* assembler) {
1892 __ EnterStubFrame(); 1892 __ EnterStubFrame();
1893 __ Push(R4); 1893 __ Push(R4);
1894 __ LoadImmediate(IP, 0); 1894 __ LoadImmediate(IP, 0);
1895 __ Push(IP); // Setup space on stack for return value. 1895 __ Push(IP); // Setup space on stack for return value.
1896 __ Push(R8); 1896 __ Push(R8);
1897 __ CallRuntime(kOptimizeInvokedFunctionRuntimeEntry, 1); 1897 __ CallRuntime(kOptimizeInvokedFunctionRuntimeEntry, 1);
1898 __ Pop(R0); // Discard argument. 1898 __ Pop(R0); // Discard argument.
1899 __ Pop(R0); // Get Code object 1899 __ Pop(R0); // Get Function object
1900 __ Pop(R4); // Restore argument descriptor. 1900 __ Pop(R4); // Restore argument descriptor.
1901 __ LeaveStubFrame(); 1901 __ LeaveStubFrame();
1902 __ mov(CODE_REG, Operand(R0)); 1902 __ ldr(CODE_REG, FieldAddress(R0, Function::code_offset()));
1903 __ ldr(R0, FieldAddress(R0, Code::entry_point_offset())); 1903 __ ldr(R1, FieldAddress(R0, Function::entry_point_offset()));
1904 __ bx(R0); 1904 __ bx(R1);
1905 __ bkpt(0); 1905 __ bkpt(0);
1906 } 1906 }
1907 1907
1908 1908
1909 // Does identical check (object references are equal or not equal) with special 1909 // Does identical check (object references are equal or not equal) with special
1910 // checks for boxed numbers. 1910 // checks for boxed numbers.
1911 // LR: return address. 1911 // LR: return address.
1912 // Return Zero condition flag set if equal. 1912 // Return Zero condition flag set if equal.
1913 // Note: A Mint cannot contain a value that would fit in Smi, a Bigint 1913 // Note: A Mint cannot contain a value that would fit in Smi, a Bigint
1914 // cannot contain a value that fits in Mint or Smi. 1914 // cannot contain a value that fits in Mint or Smi.
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
2255 } 2255 }
2256 2256
2257 2257
2258 void StubCode::GenerateFrameAwaitingMaterializationStub(Assembler* assembler) { 2258 void StubCode::GenerateFrameAwaitingMaterializationStub(Assembler* assembler) {
2259 __ bkpt(0); 2259 __ bkpt(0);
2260 } 2260 }
2261 2261
2262 } // namespace dart 2262 } // namespace dart
2263 2263
2264 #endif // defined TARGET_ARCH_ARM 2264 #endif // defined TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « runtime/vm/simulator_dbc.cc ('k') | runtime/vm/stub_code_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698