Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2418623002: [Devtools] Added divider timing to network timeline expirement (Closed)
Patch Set: Merge branch 'master' into NETWORK_TIMELINE_6_DRAW_DIVIDERS Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @param {!WebInspector.NetworkLogView} networkLogView 7 * @param {!WebInspector.NetworkLogView} networkLogView
8 * @param {!WebInspector.Setting} networkLogLargeRowsSetting 8 * @param {!WebInspector.Setting} networkLogLargeRowsSetting
9 */ 9 */
10 WebInspector.NetworkLogViewColumns = function(networkLogView, networkLogLargeRow sSetting) 10 WebInspector.NetworkLogViewColumns = function(networkLogView, networkLogLargeRow sSetting)
(...skipping 682 matching lines...) Expand 10 before | Expand all | Expand 10 after
693 if (!oldColumnConfig || (currentColumnConfig && oldHeaderId !== newHeade rId)) 693 if (!oldColumnConfig || (currentColumnConfig && oldHeaderId !== newHeade rId))
694 return false; 694 return false;
695 695
696 this._removeCustomHeader(oldHeaderId); 696 this._removeCustomHeader(oldHeaderId);
697 this._addCustomHeader(newHeaderTitle, newHeaderId, oldIndex); 697 this._addCustomHeader(newHeaderTitle, newHeaderId, oldIndex);
698 return true; 698 return true;
699 }, 699 },
700 700
701 updateDividersIfNeeded: function() 701 updateDividersIfNeeded: function()
702 { 702 {
703 // TODO(allada) Remove this code out when timeline canvas experiment is over.
703 if (Runtime.experiments.isEnabled("canvasNetworkTimeline")) 704 if (Runtime.experiments.isEnabled("canvasNetworkTimeline"))
704 return; 705 return;
705 if (!this._networkLogView.isShowing()) { 706 if (!this._networkLogView.isShowing()) {
706 this._networkLogView.scheduleRefresh(); 707 this._networkLogView.scheduleRefresh();
707 return; 708 return;
708 } 709 }
709 710
710 var timelineOffset = this._dataGrid.columnOffset("timeline"); 711 var timelineOffset = this._dataGrid.columnOffset("timeline");
711 // Position timline grid location. 712 // Position timline grid location.
712 if (timelineOffset) 713 if (timelineOffset)
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
830 divider.element.classList.toggle("network-frame-divider-selected", f alse); 831 divider.element.classList.toggle("network-frame-divider-selected", f alse);
831 }, 832 },
832 833
833 _updateRowsSize: function() 834 _updateRowsSize: function()
834 { 835 {
835 if (Runtime.experiments.isEnabled("canvasNetworkTimeline")) 836 if (Runtime.experiments.isEnabled("canvasNetworkTimeline"))
836 return; 837 return;
837 this._timelineGrid.element.classList.toggle("small", !this._networkLogLa rgeRowsSetting.get()); 838 this._timelineGrid.element.classList.toggle("small", !this._networkLogLa rgeRowsSetting.get());
838 } 839 }
839 } 840 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698