Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2418623002: [Devtools] Added divider timing to network timeline expirement (Closed)
Patch Set: Merge branch 'master' into NETWORK_TIMELINE_6_DRAW_DIVIDERS Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 /** 388 /**
389 * @param {?WebInspector.NetworkDataGridNode} node 389 * @param {?WebInspector.NetworkDataGridNode} node
390 */ 390 */
391 _setHoveredNode: function(node) 391 _setHoveredNode: function(node)
392 { 392 {
393 if (this._hoveredNode) 393 if (this._hoveredNode)
394 this._hoveredNode.element().classList.remove("hover"); 394 this._hoveredNode.element().classList.remove("hover");
395 this._hoveredNode = node; 395 this._hoveredNode = node;
396 if (this._hoveredNode) 396 if (this._hoveredNode)
397 this._hoveredNode.element().classList.add("hover"); 397 this._hoveredNode.element().classList.add("hover");
398 this._timelineColumn.setHoveredRequest(this._hoveredNode ? this._hovered Node.request() : null); 398 if (Runtime.experiments.isEnabled("canvasNetworkTimeline"))
399 this._timelineColumn.setHoveredRequest(this._hoveredNode ? this._hov eredNode.request() : null);
399 }, 400 },
400 401
401 /** 402 /**
402 * @param {!Event} event 403 * @param {!Event} event
403 */ 404 */
404 _dataGridMouseDown: function(event) 405 _dataGridMouseDown: function(event)
405 { 406 {
406 if ((!this._dataGrid.selectedNode && event.button) || event.target.enclo singNodeOrSelfWithNodeName("a")) 407 if ((!this._dataGrid.selectedNode && event.button) || event.target.enclo singNodeOrSelfWithNodeName("a"))
407 event.consume(); 408 event.consume();
408 }, 409 },
(...skipping 1437 matching lines...) Expand 10 before | Expand all | Expand 10 after
1846 * @return {boolean} 1847 * @return {boolean}
1847 */ 1848 */
1848 WebInspector.NetworkLogView._requestTimeFilter = function(windowStart, windowEnd , request) 1849 WebInspector.NetworkLogView._requestTimeFilter = function(windowStart, windowEnd , request)
1849 { 1850 {
1850 if (request.issueTime() > windowEnd) 1851 if (request.issueTime() > windowEnd)
1851 return false; 1852 return false;
1852 if (request.endTime !== -1 && request.endTime < windowStart) 1853 if (request.endTime !== -1 && request.endTime < windowStart)
1853 return false; 1854 return false;
1854 return true; 1855 return true;
1855 } 1856 }
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698