Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2418603002: Fix paint invalidation rect visualization (Closed)

Created:
4 years, 2 months ago by Xianzhu
Modified:
4 years, 2 months ago
Reviewers:
chrishtr
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix paint invalidation rect visualization Modified paint invalidation rect visualization code to parse the new layer list. Note that the visualization of rects in child layers may be incorrect because for now we don't output accumulated position and transform in the layer list. BUG=647831 Committed: https://crrev.com/a1700471e4f0a94ef8106b034662d04e9282a8c0 Cr-Commit-Position: refs/heads/master@{#424925}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/repaint_overlay.py View 4 chunks +9 lines, -17 lines 1 comment Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/repaint_overlay_unittest.py View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Xianzhu
https://codereview.chromium.org/2418603002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/repaint_overlay.py File third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/repaint_overlay.py (left): https://codereview.chromium.org/2418603002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/repaint_overlay.py#oldcode95 third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/repaint_overlay.py:95: } The above code has been no use since ...
4 years, 2 months ago (2016-10-12 20:13:23 UTC) #2
chrishtr
lgtm
4 years, 2 months ago (2016-10-12 23:16:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418603002/1
4 years, 2 months ago (2016-10-12 23:17:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 00:56:49 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 01:01:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1700471e4f0a94ef8106b034662d04e9282a8c0
Cr-Commit-Position: refs/heads/master@{#424925}

Powered by Google App Engine
This is Rietveld 408576698