Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2418583002:
Fix OfflinePageUtilsTest.CheckExistenceOfPagesWithURL. (Closed)
|
Created:
4 years, 2 months ago by fdoray Modified:
4 years, 2 months ago Reviewers:
fgorski CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix OfflinePageUtilsTest.CheckExistenceOfPagesWithURL.
Avoid a DCHECK_CURRENTLY_ON error in
OfflinePageUtilsTest.CheckExistenceOfPagesWithURL by instantiating
a content::TestBrowserThreadBundle in the test.
BUG=655252
Committed: https://crrev.com/bb8992524a92fca10ddfaa183474bd48899b4302
Cr-Commit-Position: refs/heads/master@{#424836}
Patch Set 1 #
Total comments: 2
Patch Set 2 : CR #Messages
Total messages: 16 (10 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix OfflinePageUtilsTest.CheckExistenceOfPagesWithURL. Avoid a DCHECK_CURRENTLY_ON error in OfflinePageUtilsTest.CheckExistenceOfPagesWithURL by instantiating a content::TestBrowserThreadBundle in the test. BUG= ========== to ========== Fix OfflinePageUtilsTest.CheckExistenceOfPagesWithURL. Avoid a DCHECK_CURRENTLY_ON error in OfflinePageUtilsTest.CheckExistenceOfPagesWithURL by instantiating a content::TestBrowserThreadBundle in the test. BUG=655252 ==========
fgorski@chromium.org changed reviewers: + fgorski@chromium.org
Mostly looks ok. https://codereview.chromium.org/2418583002/diff/1/chrome/browser/android/offl... File chrome/browser/android/offline_pages/offline_page_utils_unittest.cc (left): https://codereview.chromium.org/2418583002/diff/1/chrome/browser/android/offl... chrome/browser/android/offline_pages/offline_page_utils_unittest.cc:116: task_runner_->RunUntilIdle(); can you implement this one in terms of base::RunLoop().RunUntilIdle() and not put it inline everywhere?
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAnL? https://codereview.chromium.org/2418583002/diff/1/chrome/browser/android/offl... File chrome/browser/android/offline_pages/offline_page_utils_unittest.cc (left): https://codereview.chromium.org/2418583002/diff/1/chrome/browser/android/offl... chrome/browser/android/offline_pages/offline_page_utils_unittest.cc:116: task_runner_->RunUntilIdle(); On 2016/10/12 19:52:19, fgorski wrote: > can you implement this one in terms of base::RunLoop().RunUntilIdle() and not > put it inline everywhere? Done.
lgtm
The CQ bit was unchecked by fdoray@chromium.org
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Fix OfflinePageUtilsTest.CheckExistenceOfPagesWithURL. Avoid a DCHECK_CURRENTLY_ON error in OfflinePageUtilsTest.CheckExistenceOfPagesWithURL by instantiating a content::TestBrowserThreadBundle in the test. BUG=655252 ========== to ========== Fix OfflinePageUtilsTest.CheckExistenceOfPagesWithURL. Avoid a DCHECK_CURRENTLY_ON error in OfflinePageUtilsTest.CheckExistenceOfPagesWithURL by instantiating a content::TestBrowserThreadBundle in the test. BUG=655252 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix OfflinePageUtilsTest.CheckExistenceOfPagesWithURL. Avoid a DCHECK_CURRENTLY_ON error in OfflinePageUtilsTest.CheckExistenceOfPagesWithURL by instantiating a content::TestBrowserThreadBundle in the test. BUG=655252 ========== to ========== Fix OfflinePageUtilsTest.CheckExistenceOfPagesWithURL. Avoid a DCHECK_CURRENTLY_ON error in OfflinePageUtilsTest.CheckExistenceOfPagesWithURL by instantiating a content::TestBrowserThreadBundle in the test. BUG=655252 Committed: https://crrev.com/bb8992524a92fca10ddfaa183474bd48899b4302 Cr-Commit-Position: refs/heads/master@{#424836} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/bb8992524a92fca10ddfaa183474bd48899b4302 Cr-Commit-Position: refs/heads/master@{#424836} |
