ui/views/controls/menu/menu_scroll_view_container.cc - Issue 2418523004: Makes Chrome's app menu have a vertical orientation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_scroll_view_container.cc

Issue 2418523004: Makes Chrome's app menu have a vertical orientation. (Closed)

Patch Set: Moved clarifying comments to a previous line. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_scroll_view_container.cc

diff --git a/ui/views/controls/menu/menu_scroll_view_container.cc b/ui/views/controls/menu/menu_scroll_view_container.cc

index a126820718be5c63b9c5a5aadc83d15bd12064d6..0612dfff91a44aca7c3f9833e3190aa5470b487a 100644

--- a/ui/views/controls/menu/menu_scroll_view_container.cc

+++ b/ui/views/controls/menu/menu_scroll_view_container.cc

@@ -260,8 +260,6 @@ void MenuScrollViewContainer::GetAccessibleState(

ui::AXViewState* state) {

// Get the name from the submenu view.

content_view_->GetAccessibleState(state);

- // Now change the role.

state->role = ui::AX_ROLE_MENU_BAR;

}