Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2418433003: Don't base android lint version off of android sdk version. (Closed)

Created:
4 years, 2 months ago by agrieve
Modified:
4 years, 2 months ago
Reviewers:
estevenson
CC:
chromium-reviews, ghost stip (do not use)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't base android lint version off of android sdk version. If downstream overrides sdk version, we don't want the lint version to change. BUG=623989 Committed: https://crrev.com/11837e363c671aa15024b9d1228057fc2bacd6eb Cr-Commit-Position: refs/heads/master@{#424847}

Patch Set 1 #

Patch Set 2 : 24->23 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/config/android/config.gni View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
estevenson
lgtm
4 years, 2 months ago (2016-10-12 20:30:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418433003/20001
4 years, 2 months ago (2016-10-12 20:33:27 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 21:00:07 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 21:06:17 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/11837e363c671aa15024b9d1228057fc2bacd6eb
Cr-Commit-Position: refs/heads/master@{#424847}

Powered by Google App Engine
This is Rietveld 408576698