chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java - Issue 2418403003: Enable the "Browse the Physical Web" button only when Physical Web is ON.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

Issue 2418403003: Enable the "Browse the Physical Web" button only when Physical Web is ON. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

index 4ad71134d27edbe753a11e4e73eafa1ebc7b40e4..76f5372ba535cdc76ba5f65d72d6434c92d7de0d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java

@@ -135,10 +135,14 @@ public class PhysicalWebDiagnosticsPage extends BasicNativePage {

|| !isLocationPermissionGranted

|| !isPreferenceEnabled) {

prerequisitesResult = Utils.RESULT_FAILURE;

+ mLaunchButton.setEnabled(false);

MuVen 2016/10/19 11:36:46 NIT: Remove this extra line.

billyjay 2016/10/19 11:59:31 Done.

} else if (bluetoothStatus == Utils.RESULT_INDETERMINATE) {

prerequisitesResult = Utils.RESULT_INDETERMINATE;

+ mLaunchButton.setEnabled(false);

}

MuVen 2016/10/19 11:36:46 NIT: Remove this extra line.

billyjay 2016/10/19 11:59:31 Done.

sb.append("<h2>Status</h2>");

sb.append("Physical Web is ");

« no previous file with comments | « no previous file | no next file » | no next file with comments »