Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2418403003:
Enable the "Browse the Physical Web" button only when Physical Web is ON. (Closed)
DescriptionEnable the "Browse the Physical Web" button only when Physical Web is ON.
Enable the "Browse the Physical Web" button only when Physical Web is ON.
Currently "Browse the Physical Web" button is enabled even when Physical Web is
OFF. This patch fixes this issue.
BUG=656577
Committed: https://crrev.com/5b5a21061a6aa8be7cc3b8b6aafa56256bb91e60
Cr-Commit-Position: refs/heads/master@{#430530}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Addressed review comments #
Messages
Total messages: 26 (10 generated)
PTAL at the patch
On 2016/10/17 13:45:26, billy.jayan wrote: > PTAL at the patch PTAL at Writing change list descriptions @ https://www.chromium.org/developers/contributing-code . for easier log message viewing in terminals. Please add corresponding owner;
Description was changed from ========== [Physical Web] Enables the "Browse the Physical Web" button only when Physical Web is ON. At present, "Browse the Physical Web" button enabled even when Physical Web is OFF, and that doesn't seems correct. This patch make the button enabled only if all prerequisits are met. BUG=656577 ========== to ========== Enable the "Browse the Physical Web" button only when Physical Web is ON. Enable the "Browse the Physical Web" button only when Physical Web is ON. Currently "Browse the Physical Web" button is enabled even when Physical Web is OFF. This patch fixes this issue. BUG=656577 ==========
billy.jayan@samsung.com changed reviewers: + animohan@chromium.org
@muven, description changed. @animohan PTAL.
sataya.m@samsung.com changed reviewers: + sataya.m@samsung.com
https://codereview.chromium.org/2418403003/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java (right): https://codereview.chromium.org/2418403003/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java:139: NIT: Remove this extra line. https://codereview.chromium.org/2418403003/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java:145: NIT: Remove this extra line.
Thanks for your inputs. I have addressed them in Patch Set 2. https://codereview.chromium.org/2418403003/diff/1/chrome/android/java/src/org... File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java (right): https://codereview.chromium.org/2418403003/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java:139: On 2016/10/19 11:36:46, MuVen wrote: > NIT: Remove this extra line. Done. https://codereview.chromium.org/2418403003/diff/1/chrome/android/java/src/org... chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebDiagnosticsPage.java:145: On 2016/10/19 11:36:46, MuVen wrote: > NIT: Remove this extra line. Done.
lgtm
LGTM from My end. I would transfer to animohan for his comments.
sataya.m@samsung.com changed reviewers: + mattreynolds@chromium.org
+adding mattreynolds. @mattreynolds, PTAL.
On 2016/10/20 17:40:36, MuVen wrote: > +adding mattreynolds. > > @mattreynolds, PTAL. lgtm
The CQ bit was checked by billy.jayan@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
billy.jayan@samsung.com changed reviewers: + nyquist@chromium.org
@nyquist, PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm
The CQ bit was checked by billy.jayan@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable the "Browse the Physical Web" button only when Physical Web is ON. Enable the "Browse the Physical Web" button only when Physical Web is ON. Currently "Browse the Physical Web" button is enabled even when Physical Web is OFF. This patch fixes this issue. BUG=656577 ========== to ========== Enable the "Browse the Physical Web" button only when Physical Web is ON. Enable the "Browse the Physical Web" button only when Physical Web is ON. Currently "Browse the Physical Web" button is enabled even when Physical Web is OFF. This patch fixes this issue. BUG=656577 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Enable the "Browse the Physical Web" button only when Physical Web is ON. Enable the "Browse the Physical Web" button only when Physical Web is ON. Currently "Browse the Physical Web" button is enabled even when Physical Web is OFF. This patch fixes this issue. BUG=656577 ========== to ========== Enable the "Browse the Physical Web" button only when Physical Web is ON. Enable the "Browse the Physical Web" button only when Physical Web is ON. Currently "Browse the Physical Web" button is enabled even when Physical Web is OFF. This patch fixes this issue. BUG=656577 Committed: https://crrev.com/5b5a21061a6aa8be7cc3b8b6aafa56256bb91e60 Cr-Commit-Position: refs/heads/master@{#430530} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/5b5a21061a6aa8be7cc3b8b6aafa56256bb91e60 Cr-Commit-Position: refs/heads/master@{#430530} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
