Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Side by Side Diff: content/browser/android/synchronous_compositor_observer.h

Issue 2418383002: sync compositor: Signal async frame on IO thread (Closed)
Patch Set: bad_message, and minor cleanups Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_ANDROID_SYNCHRONOUS_COMPOSITOR_OBSERVER_H_ 5 #ifndef CONTENT_BROWSER_ANDROID_SYNCHRONOUS_COMPOSITOR_OBSERVER_H_
6 #define CONTENT_BROWSER_ANDROID_SYNCHRONOUS_COMPOSITOR_OBSERVER_H_ 6 #define CONTENT_BROWSER_ANDROID_SYNCHRONOUS_COMPOSITOR_OBSERVER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "content/public/browser/render_process_host_observer.h" 11 #include "base/synchronization/lock.h"
12 #include "content/public/browser/android/synchronous_compositor.h"
13 #include "content/public/browser/browser_message_filter.h"
12 #include "ui/android/window_android_observer.h" 14 #include "ui/android/window_android_observer.h"
13 15
14 namespace ui { 16 namespace ui {
15 class WindowAndroid; 17 class WindowAndroid;
16 } 18 }
17 19
18 namespace content { 20 namespace content {
19 21
22 class RenderProcessHost;
20 class SynchronousCompositorHost; 23 class SynchronousCompositorHost;
21 24
22 // SynchronousCompositor class that's tied to the lifetime of a 25 // TODO(boliu): Rename this to SynchronousCompositorFilter.
23 // RenderProcessHost. Responsible for its own lifetime. 26 class SynchronousCompositorObserver : public ui::WindowAndroidObserver,
24 class SynchronousCompositorObserver : public RenderProcessHostObserver, 27 public BrowserMessageFilter {
25 public ui::WindowAndroidObserver {
26 public: 28 public:
27 static SynchronousCompositorObserver* GetOrCreateFor(int process_id); 29 explicit SynchronousCompositorObserver(int process_id);
28
29 // RenderProcessHostObserver overrides.
30 void RenderProcessHostDestroyed(RenderProcessHost* host) override;
31 30
32 // WindowAndroidObserver overrides. 31 // WindowAndroidObserver overrides.
33 void OnCompositingDidCommit() override; 32 void OnCompositingDidCommit() override;
34 void OnRootWindowVisibilityChanged(bool visible) override; 33 void OnRootWindowVisibilityChanged(bool visible) override;
35 void OnAttachCompositor() override; 34 void OnAttachCompositor() override;
36 void OnDetachCompositor() override; 35 void OnDetachCompositor() override;
37 void OnVSync(base::TimeTicks frame_time, 36 void OnVSync(base::TimeTicks frame_time,
38 base::TimeDelta vsync_period) override; 37 base::TimeDelta vsync_period) override;
39 void OnActivityStopped() override; 38 void OnActivityStopped() override;
40 void OnActivityStarted() override; 39 void OnActivityStarted() override;
41 40
41 // BrowserMessageFilter overrides.
42 bool OnMessageReceived(const IPC::Message& message) override;
43
42 void SyncStateAfterVSync(ui::WindowAndroid* window_android, 44 void SyncStateAfterVSync(ui::WindowAndroid* window_android,
43 SynchronousCompositorHost* compositor_host); 45 SynchronousCompositorHost* compositor_host);
46 void SetFrameFuture(
47 const int routing_id,
dcheng 2016/10/21 06:42:56 Nit: usually const int, etc don't have a lot of me
boliu 2016/10/21 15:15:32 Done.
48 const scoped_refptr<SynchronousCompositor::FrameFuture>& frame_future);
dcheng 2016/10/21 06:42:56 Nit: scoped_refptr<> frame_future
boliu 2016/10/21 15:15:32 Done.
44 49
45 private: 50 private:
46 explicit SynchronousCompositorObserver(int process_id);
47 ~SynchronousCompositorObserver() override; 51 ~SynchronousCompositorObserver() override;
48 52
53 bool ReceiveFrame(const IPC::Message& message);
54
49 RenderProcessHost* const render_process_host_; 55 RenderProcessHost* const render_process_host_;
50 56
51 // For synchronizing renderer state after a vsync. 57 // For synchronizing renderer state after a vsync.
52 ui::WindowAndroid* window_android_in_vsync_; 58 ui::WindowAndroid* window_android_in_vsync_;
53 std::vector<SynchronousCompositorHost*> 59 std::vector<SynchronousCompositorHost*>
54 compositor_host_pending_renderer_state_; 60 compositor_host_pending_renderer_state_;
55 61
62 base::Lock future_map_lock_; // Protects |future_map_|.
63 using FrameFutureMap =
64 std::map<int, scoped_refptr<SynchronousCompositor::FrameFuture>>;
65 FrameFutureMap future_map_;
66
56 DISALLOW_COPY_AND_ASSIGN(SynchronousCompositorObserver); 67 DISALLOW_COPY_AND_ASSIGN(SynchronousCompositorObserver);
57 }; 68 };
58 69
59 } // namespace content 70 } // namespace content
60 71
61 #endif // CONTENT_BROWSER_ANDROID_SYNCHRONOUS_COMPOSITOR_OBSERVER_H_ 72 #endif // CONTENT_BROWSER_ANDROID_SYNCHRONOUS_COMPOSITOR_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698