Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2418373002: Reduce FOR_EACH_OBSERVER usage in content/browser/service_worker (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce FOR_EACH_OBSERVER usage in content/browser/service_worker Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/e092a95ec32bc04e0dab4537b7d486e8ab1a0f86 Cr-Commit-Position: refs/heads/master@{#425619}

Patch Set 1 #

Total comments: 1

Patch Set 2 : add bracket #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -67 lines) Patch
M content/browser/service_worker/embedded_worker_instance.cc View 1 12 chunks +34 lines, -23 lines 0 comments Download
M content/browser/service_worker/service_worker_registration.cc View 1 3 chunks +12 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 15 chunks +47 lines, -36 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Eric Willigers
4 years, 2 months ago (2016-10-15 21:59:44 UTC) #6
horo
lgtm with a nit. https://codereview.chromium.org/2418373002/diff/1/content/browser/service_worker/service_worker_registration.cc File content/browser/service_worker/service_worker_registration.cc (right): https://codereview.chromium.org/2418373002/diff/1/content/browser/service_worker/service_worker_registration.cc#newcode319 content/browser/service_worker/service_worker_registration.cc:319: if (activating_version->skip_waiting()) Nit: please add ...
4 years, 2 months ago (2016-10-17 02:22:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418373002/20001
4 years, 2 months ago (2016-10-17 05:13:56 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-17 05:19:36 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 05:22:05 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e092a95ec32bc04e0dab4537b7d486e8ab1a0f86
Cr-Commit-Position: refs/heads/master@{#425619}

Powered by Google App Engine
This is Rietveld 408576698