Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6847)

Unified Diff: chrome/browser/ui/webui/print_preview/extension_printer_handler.cc

Issue 2418353002: Allow interfaceClass USB device permissions (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview/extension_printer_handler.cc
diff --git a/chrome/browser/ui/webui/print_preview/extension_printer_handler.cc b/chrome/browser/ui/webui/print_preview/extension_printer_handler.cc
index 0894f3666ca95f2b705ab49d26ee0bb5a907729c..871efc0c06aa9739bd7b4e2faeb20b82a6d4b84e 100644
--- a/chrome/browser/ui/webui/print_preview/extension_printer_handler.cc
+++ b/chrome/browser/ui/webui/print_preview/extension_printer_handler.cc
@@ -343,12 +343,12 @@ void ExtensionPrinterHandler::OnUsbDevicesEnumerated(
permissions_manager->GetForExtension(extension->id());
for (const auto& device : devices) {
if (manifest_data->SupportsDevice(device)) {
- extensions::UsbDevicePermission::CheckParam param(
- device->vendor_id(), device->product_id(),
- extensions::UsbDevicePermissionData::UNSPECIFIED_INTERFACE);
+ std::unique_ptr<extensions::UsbDevicePermission::CheckParam> param =
+ extensions::UsbDevicePermission::CheckParam::ForUsbDevice(
+ extension.get(), device.get());
if (device_permissions->FindUsbDeviceEntry(device) ||
extension->permissions_data()->CheckAPIPermissionWithParam(
- extensions::APIPermission::kUsbDevice, &param)) {
+ extensions::APIPermission::kUsbDevice, param.get())) {
// Skip devices the extension already has permission to access.
continue;
}

Powered by Google App Engine
This is Rietveld 408576698