Issue 2418323002: Make fatal out of memory messages uniform.

Issue 2418323002: Make fatal out of memory messages uniform. (Closed)

Created:
4 years, 2 months ago by rmacnak

Modified:
4 years, 2 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, turnidge, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Make fatal out of memory messages uniform. Add checks in a few more places with large allocations. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/61bf8abd754a7ee5e2fba49db1b192ee18e1c540

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -8 lines)			Patch
M	runtime/platform/assert.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/platform/hashmap.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/platform/text_buffer.cc	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/vm/clustered_snapshot.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/scavenger.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/service.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/zone.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

Cutch

On 2016/10/19 22:44:24, Florian Schneider wrote: > Lgtm Why not a FATAL_OOM macro where you ...

4 years, 2 months ago (2016-10-19 22:49:53 UTC) #4

rmacnak

Added OUT_OF_MEMORY next to UNIMPLEMENTED and UNREACHABLE.

4 years, 2 months ago (2016-10-19 23:37:13 UTC) #5

rmacnak

4 years, 2 months ago (2016-10-19 23:38:05 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
61bf8abd754a7ee5e2fba49db1b192ee18e1c540 (presubmit successful).