Issue 2418283003: [Merge M55] android: Register Display lazily

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2418283003: [Merge M55] android: Register Display lazily (Closed)

Created:
4 years, 2 months ago by boliu

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews, agrieve+watch_chromium.org

Target Ref:
refs/pending/branch-heads/2883

Project:
chromium

Visibility:
Public.

[Merge M55] android: Register Display lazily Apparently trying to look up the Display inside onDisplayAdded returns null, and causing crashes. Lazily register display to be added on first use instead to avoid this crash. BUG=655241, 625089 Review-Url: https://codereview.chromium.org/2420453002 Cr-Commit-Position: refs/heads/master@{#424901} (cherry picked from commit c1d7c92e975b51de35471b539d6840ceabd68374) Committed: https://chromium.googlesource.com/chromium/src/+/4912b292e1176dae1976affdfa6ab15b0b7eda33

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -13 lines)			Patch
	M	ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java	View		5 chunks	+17 lines, -11 lines	0 comments	Download

Total messages: 2 (1 generated)

boliu

4 years, 2 months ago (2016-10-14 22:31:24 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4912b292e1176dae1976affdfa6ab15b0b7eda33.