Add IGNORE_DEPS_CHANGES flag and coverage builder.

Add IGNORE_DEPS_CHANGES flag and coverage builder.

Add a flag to "chromium" recipe module to export the IGNORE_DEPS_CHANGES
environment variable. Since this is used outside of the "build"
repository, add a fake builder to exercise this option for coverage.

BUG=chromium:648308
TEST=None

Committed: https://chromium.googlesource.com/chromium/tools/build/+/02bbb17974a70e1bb198ee4243d830ff258d1bb8

[Dirk Pranke, 2016-10-15 22:40:30]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-10-15 22:40:31]

lgtm

https://codereview.chromium.org/2418233002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium/api.py (right):

https://codereview.chromium.org/2418233002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium/api.py:83: ret['IGNORE_DEPS_CHANGES'] =
'1'
We shouldn't be using environment variables for anything related to how things
are built; this should be a GN argument like anything else.

However, that can be fixed in a follow-up patch as long as we file a bug for
this.

[dnj, 2016-10-16 16:44:28]

https://codereview.chromium.org/2418233002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/chromium/api.py (right):

https://codereview.chromium.org/2418233002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/chromium/api.py:83: ret['IGNORE_DEPS_CHANGES'] =
'1'
On 2016/10/15 22:40:31, Dirk Pranke wrote:
> We shouldn't be using environment variables for anything related to how things
> are built; this should be a GN argument like anything else.
> 
> However, that can be fixed in a follow-up patch as long as we file a bug for
> this.

Agreed. IMO the thing to do here is to make an actual GVC image target in GN and
just build that. This is just a literal transcription of what the previous
builder was doing.

[dnj, 2016-10-16 16:44:59]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2016-10-16 16:45:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-16 17:25:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-16 17:25:16]

Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/31e733a0f3771510)

[dnj, 2016-10-17 16:39:32]

The CQ bit was checked by dnj@chromium.org

[dnj, 2016-10-17 16:39:32]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2418233002/#ps20001
(title: "More appropriate place for coverage builder.")

[commit-bot: I haz the power, 2016-10-17 16:39:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dnj, 2016-10-17 16:39:57]

The CQ bit was unchecked by dnj@chromium.org

[dnj, 2016-10-17 16:41:03]

The CQ bit was checked by dnj@chromium.org

[dnj, 2016-10-17 16:41:05]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2418233002/#ps40001
(title: "Remove old expectation from patch.")

[commit-bot: I haz the power, 2016-10-17 16:41:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 16:50:32]

Description was changed from

==========
Add IGNORE_DEPS_CHANGES flag and coverage builder.

Add a flag to "chromium" recipe module to export the IGNORE_DEPS_CHANGES
environment variable. Since this is used outside of the "build"
repository, add a fake builder to exercise this option for coverage.

BUG=chromium:648308
TEST=None
==========

to

==========
Add IGNORE_DEPS_CHANGES flag and coverage builder.

Add a flag to "chromium" recipe module to export the IGNORE_DEPS_CHANGES
environment variable. Since this is used outside of the "build"
repository, add a fake builder to exercise this option for coverage.

BUG=chromium:648308
TEST=None

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/02bbb17974a70e1bb198...
==========

[commit-bot: I haz the power, 2016-10-17 16:50:33]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/02bbb17974a70e1bb198...

[dnj, 2016-10-17 18:23:51]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2424113002/ by dnj@chromium.org.

The reason for reverting is: Team says they don't need the builder that this
supports, so remove the code..