chrome/browser/notifications/notification_platform_bridge_android.h - Issue 2418153002: Hooking up Android N inline notification replies end-to-end

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_platform_bridge_android.h

Issue 2418153002: Hooking up Android N inline notification replies end-to-end (Closed)

Patch Set: Responding to review of patch 1 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/native_notification_display_service.cc ('k') | chrome/browser/notifications/notification_platform_bridge_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_platform_bridge_android.h

diff --git a/chrome/browser/notifications/notification_platform_bridge_android.h b/chrome/browser/notifications/notification_platform_bridge_android.h

index ac0e6eddce1a8735b394b06fe8f95224fe9fc493..f68be0f118efa100365e869b02d02e75d9f6f372 100644

--- a/chrome/browser/notifications/notification_platform_bridge_android.h

+++ b/chrome/browser/notifications/notification_platform_bridge_android.h

@@ -47,7 +47,8 @@ class NotificationPlatformBridgeAndroid : public NotificationPlatformBridge {

jboolean incognito,

const base::android::JavaParamRef<jstring>& java_tag,

const base::android::JavaParamRef<jstring>& java_webapk_package,

- jint action_index);

+ jint action_index,

+ const base::android::JavaParamRef<_jstring*>& java_reply);

Peter Beverloo 2016/10/17 14:54:09 update

awdf 2016/10/17 15:40:15 Done.

// Called by the Java implementation when the notification has been closed.

void OnNotificationClosed(