Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2418143003: [ARC] Converts part of ios/web to ARC. (Closed)

Created:
4 years, 2 months ago by stkhapugin
Modified:
4 years, 2 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Notable changes:None BUG=651830 Committed: https://crrev.com/c8b7ee41e0e7a263b67c33fc0f933ef2eafe9684 Cr-Commit-Position: refs/heads/master@{#425645}

Patch Set 1 #

Patch Set 2 : compile guards #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -20 lines) Patch
M ios/web/BUILD.gn View 2 chunks +10 lines, -10 lines 0 comments Download
M ios/web/public/web_state/ui/crw_generic_content_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/js/crw_js_window_id_manager.mm View 5 chunks +9 lines, -5 lines 0 comments Download
M ios/web/web_state/js/page_script_util.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/page_viewport_state.mm View 1 2 chunks +5 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_generic_content_view.mm View 1 2 chunks +5 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_touch_tracking_recognizer.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_touch_tracking_recognizer.mm View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
stkhapugin
ptal
4 years, 2 months ago (2016-10-14 19:04:11 UTC) #7
sdefresne
lgtm
4 years, 2 months ago (2016-10-16 22:48:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418143003/20001
4 years, 2 months ago (2016-10-17 08:59:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-17 09:53:25 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 09:55:25 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c8b7ee41e0e7a263b67c33fc0f933ef2eafe9684
Cr-Commit-Position: refs/heads/master@{#425645}

Powered by Google App Engine
This is Rietveld 408576698