Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2418123002: Fix interpreted regexp build wrt tracing. (Closed)

Created:
4 years, 2 months ago by Yang
Modified:
4 years, 2 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix interpreted regexp build wrt tracing. R=jgruber@chromium.org Committed: https://crrev.com/859eb7bdbc996de91662da2de5c4f9bdafc25872 Cr-Commit-Position: refs/heads/master@{#40312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/regexp/regexp-macro-assembler-tracer.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 2 months ago (2016-10-14 10:53:28 UTC) #1
jgruber
lgtm
4 years, 2 months ago (2016-10-14 11:43:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418123002/1
4 years, 2 months ago (2016-10-14 11:46:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 12:23:39 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 12:23:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/859eb7bdbc996de91662da2de5c4f9bdafc25872
Cr-Commit-Position: refs/heads/master@{#40312}

Powered by Google App Engine
This is Rietveld 408576698