Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2418113002: Revert "Roll src/third_party/boringssl/src 0d81373f9..1991af690" (https://codereview.chromium.org/2… (Closed)

Created:
4 years, 2 months ago by hans
Modified:
4 years, 2 months ago
Reviewers:
davidben
CC:
chromium-reviews, msramek+watch_chromium.org, jam, cbentzel+watch_chromium.org, raymes+watch_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, caseq+blink_chromium.org, darin-cc_chromium.org, lushnikov+blink_chromium.org, asvitkine+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, apavlov+blink_chromium.org, markusheintz_, blink-reviews-api_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Roll src/third_party/boringssl/src 0d81373f9..1991af690" (https://codereview.chromium.org/2395323002) It broke the Linux ASan build of boringssl_bytestring_test. (Reverting manually; Rietveld complained about some file being too large.) Original description: > Roll src/third_party/boringssl/src 0d81373f9..1991af690 > > https://boringssl.googlesource.com/boringssl/+log/0d81373f9169637ff935449227be924c08bf1ec5..1991af69006a8fe4faf9b80b2340688846e62514 > > This requires a change in WebCrypto. BoringSSL's > https://boringssl.googlesource.com/boringssl/+/97227dc52d9e6620c8b83eb1dd4d45edf51d9d7f > switches to aligning with upstream's APIs for AES key wrap. > > This also teaches DevTools how to handle the new draft TLS 1.3 ciphers > and adds them to histograms.xml. See > https://tools.ietf.org/html/draft-ietf-tls-tls13-16#appendix-A.4 > > Finally, it adds the CECPQ1 experimental ciphers which we forgot to add > there earlier. > > BUG=639495 > Committed: https://crrev.com/0f3127d8ff177305fe9992e87b4f096598fb787a > Cr-Commit-Position: refs/heads/master@{#425147} BUG=639495, 655938 TBR=davidben Committed: https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c Cr-Commit-Position: refs/heads/master@{#425294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -452 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/chrome_security_state_model_client.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ssl/chrome_security_state_model_client_unittest.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 2 chunks +3 lines, -13 lines 0 comments Download
M components/webcrypto/algorithms/aes_kw.cc View 3 chunks +41 lines, -62 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M net/ssl/ssl_cipher_suite_names.h View 1 chunk +1 line, -5 lines 0 comments Download
M net/ssl/ssl_cipher_suite_names.cc View 5 chunks +30 lines, -38 lines 0 comments Download
M net/ssl/ssl_cipher_suite_names_unittest.cc View 5 chunks +15 lines, -61 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/network/ResourceResponse.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLResponse.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/boringssl/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/boringssl/BUILD.generated.gni View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/boringssl/err_data.c View 6 chunks +187 lines, -193 lines 0 comments Download
M third_party/boringssl/linux-x86_64/crypto/ec/p256-x86_64-asm.S View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/boringssl/mac-x86_64/crypto/ec/p256-x86_64-asm.S View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/ec/p256-x86_64-asm.asm View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418113002/1
4 years, 2 months ago (2016-10-14 10:02:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-14 11:30:36 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 11:32:22 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c048c38b523c078d567996a8d3263163b710a04c
Cr-Commit-Position: refs/heads/master@{#425294}

Powered by Google App Engine
This is Rietveld 408576698