Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 24181002: Add a test for color bitmap fonts. (Closed)

Created:
7 years, 3 months ago by djsollen
Modified:
7 years, 3 months ago
Reviewers:
violets, reed1, behdad
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add a test for color bitmap fonts. This CL also includes a sample font from https://code.google.com/p/color-emoji/ R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=11317

Patch Set 1 #

Total comments: 1

Patch Set 2 : spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, --1 lines) Patch
A gm/coloremoji.cpp View 1 1 chunk +116 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A resources/Funkster.ttf View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
djsollen
Behdad, are you the author of the funkster.ttf file?
7 years, 3 months ago (2013-09-16 17:13:20 UTC) #1
djsollen
new patch set coming soon with the spacing fixed. https://codereview.chromium.org/24181002/diff/1/gm/coloremoji.cpp File gm/coloremoji.cpp (right): https://codereview.chromium.org/24181002/diff/1/gm/coloremoji.cpp#newcode18 gm/coloremoji.cpp:18: ...
7 years, 3 months ago (2013-09-16 17:14:14 UTC) #2
behdad_google
On 2013/09/16 17:13:20, djsollen wrote: > Behdad, are you the author of the funkster.ttf file? ...
7 years, 3 months ago (2013-09-16 17:25:46 UTC) #3
reed1
lgtm
7 years, 3 months ago (2013-09-17 14:35:51 UTC) #4
reed1
lgtm lgtm
7 years, 3 months ago (2013-09-17 14:35:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/djsollen@google.com/24181002/7001
7 years, 3 months ago (2013-09-17 14:40:10 UTC) #6
djsollen
7 years, 3 months ago (2013-09-17 15:30:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r11317 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698