DBC: Fix CheckClass bug. Add some intrinsics

DBC: Fix CheckClass bug. Add some intrinsics

Flutter layout benchmark 8.5k us -> 6k us.

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/c8970d05248dc789c8422491451349d2c5437291

[zra, 2016-10-17 14:46:42]

Description was changed from

==========
DBC: Fix CheckClass bug. Add intrinsics
==========

to

==========
DBC: Fix CheckClass bug. Add some intrinsics

Flutter layout benchmark 8.5k us -> 6k us.
==========

[zra, 2016-10-17 14:46:55]

zra@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-10-17 16:58:54]

lgtm

https://codereview.chromium.org/2418073002/diff/20001/runtime/vm/simulator_db...
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2418073002/diff/20001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:283: if (!obj2->IsHeapObject()) {
I'd rather use obj2->IsSmi() for readability avoiding the negation.

[zra, 2016-10-17 17:20:59]

Description was changed from

==========
DBC: Fix CheckClass bug. Add some intrinsics

Flutter layout benchmark 8.5k us -> 6k us.
==========

to

==========
DBC: Fix CheckClass bug. Add some intrinsics

Flutter layout benchmark 8.5k us -> 6k us.

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c8970d05248dc789c8422491451349d2c5437291
==========

[zra, 2016-10-17 17:21:01]

Committed patchset #2 (id:20001) manually as
c8970d05248dc789c8422491451349d2c5437291 (presubmit successful).

[zra, 2016-10-17 17:22:51]

https://codereview.chromium.org/2418073002/diff/20001/runtime/vm/simulator_db...
File runtime/vm/simulator_dbc.cc (right):

https://codereview.chromium.org/2418073002/diff/20001/runtime/vm/simulator_db...
runtime/vm/simulator_dbc.cc:283: if (!obj2->IsHeapObject()) {
On 2016/10/17 16:58:54, Florian Schneider wrote:
> I'd rather use obj2->IsSmi() for readability avoiding the negation.

IsSmi() calls GetClassId() which calls ptr() which only makes sense on a heap
object =(