Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Issue 2418043003: Add chrome://history to WebUI.CreatedForUrl histogram values. (Closed)

Created:
4 years, 2 months ago by calamity
Modified:
4 years, 2 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome://history to WebUI.CreatedForUrl histogram values. BUG=None NO_DEPENDENCY_CHECKS=true Committed: https://crrev.com/41961c0516403c5d1a605dff71b146c59d391360 Cr-Commit-Position: refs/heads/master@{#427006}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
calamity
4 years, 2 months ago (2016-10-14 09:38:24 UTC) #2
Ilya Sherman
lgtm
4 years, 2 months ago (2016-10-14 18:20:57 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2420583003 Patch 1). Please resolve the dependency and ...
4 years, 2 months ago (2016-10-14 18:21:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418043003/1
4 years, 2 months ago (2016-10-15 21:54:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/87931)
4 years, 2 months ago (2016-10-15 21:56:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2418043003/20001
4 years, 2 months ago (2016-10-24 00:13:07 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-24 01:09:59 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-24 01:13:06 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/41961c0516403c5d1a605dff71b146c59d391360
Cr-Commit-Position: refs/heads/master@{#427006}

Powered by Google App Engine
This is Rietveld 408576698