|
|
Created:
4 years, 2 months ago by calamity Modified:
4 years, 2 months ago Reviewers:
Ilya Sherman CC:
chromium-reviews, asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd chrome://history to WebUI.CreatedForUrl histogram values.
BUG=None
NO_DEPENDENCY_CHECKS=true
Committed: https://crrev.com/41961c0516403c5d1a605dff71b146c59d391360
Cr-Commit-Position: refs/heads/master@{#427006}
Patch Set 1 #Patch Set 2 : rebase #Messages
Total messages: 22 (14 generated)
calamity@chromium.org changed reviewers: + isherman@chromium.org
The CQ bit was checked by isherman@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2420583003 Patch 1). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Description was changed from ========== Add chrome://history to WebUI.CreatedForUrl histogram values. BUG=None ========== to ========== Add chrome://history to WebUI.CreatedForUrl histogram values. BUG=None NO_DEPENDENCY_CHECKS=true ==========
The CQ bit was checked by calamity@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by calamity@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by calamity@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from isherman@chromium.org Link to the patchset: https://codereview.chromium.org/2418043003/#ps20001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add chrome://history to WebUI.CreatedForUrl histogram values. BUG=None NO_DEPENDENCY_CHECKS=true ========== to ========== Add chrome://history to WebUI.CreatedForUrl histogram values. BUG=None NO_DEPENDENCY_CHECKS=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add chrome://history to WebUI.CreatedForUrl histogram values. BUG=None NO_DEPENDENCY_CHECKS=true ========== to ========== Add chrome://history to WebUI.CreatedForUrl histogram values. BUG=None NO_DEPENDENCY_CHECKS=true Committed: https://crrev.com/41961c0516403c5d1a605dff71b146c59d391360 Cr-Commit-Position: refs/heads/master@{#427006} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/41961c0516403c5d1a605dff71b146c59d391360 Cr-Commit-Position: refs/heads/master@{#427006} |