third_party/WebKit/LayoutTests/http/tests/navigation/post-with-modifier.html - Issue 2417983002: Form submissions opening in a new window don't need special treatment anymore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/navigation/post-with-modifier.html

Issue 2417983002: Form submissions opening in a new window don't need special treatment anymore. (Closed)

Patch Set: Add support for NEW_WINDOW disposition in content::Shell::OpenURLFromTab. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/shell/browser/shell.cc ('K') | « content/shell/browser/shell.cc ('k') | third_party/WebKit/LayoutTests/http/tests/navigation/resources/post-with-modifier.php » ('j') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/navigation/post-with-modifier.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/navigation/post-with-modifier.html b/third_party/WebKit/LayoutTests/http/tests/navigation/post-with-modifier.html

index 16ba0716034f559bf43be2f178bb756d652b133b..7bbb376947d15a849d0bed88492055a6fb127601 100644

--- a/third_party/WebKit/LayoutTests/http/tests/navigation/post-with-modifier.html

+++ b/third_party/WebKit/LayoutTests/http/tests/navigation/post-with-modifier.html

@@ -32,6 +32,9 @@ if (window.testRunner) {

eventSender.mouseUp(0, ['shiftKey']);

};

+ // Shift-clicking doesn't set window.opener, so we allow the new window

+ // to find the opener using the name being set below.

+ window.name = "mainTestWindow";

Łukasz Anforowicz 2016/10/19 20:48:50 The change in window.opener behavior is a bit worr

window.addEventListener('message', function(e) {

concludeTest(e.data);

});