third_party/WebKit/LayoutTests/http/tests/navigation/resources/post-with-modifier.php - Issue 2417983002: Form submissions opening in a new window don't need special treatment anymore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/navigation/resources/post-with-modifier.php

Issue 2417983002: Form submissions opening in a new window don't need special treatment anymore. (Closed)

Patch Set: Using params.source_site_instance for consistency with //chrome layer. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/shell/browser/shell.cc ('K') | « third_party/WebKit/LayoutTests/http/tests/navigation/post-with-modifier.html ('k') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/navigation/resources/post-with-modifier.php

diff --git a/third_party/WebKit/LayoutTests/http/tests/navigation/resources/post-with-modifier.php b/third_party/WebKit/LayoutTests/http/tests/navigation/resources/post-with-modifier.php

index 797053fd0f63b1864f705c53c685911094796596..e4e02c06d12f1bb060bc99ef05e35bda24a804f7 100644

--- a/third_party/WebKit/LayoutTests/http/tests/navigation/resources/post-with-modifier.php

+++ b/third_party/WebKit/LayoutTests/http/tests/navigation/resources/post-with-modifier.php

@@ -1,12 +1,8 @@

-if (window.opener) {

- var data = {

- 'method': '<?=$_SERVER['REQUEST_METHOD'] ?>',

- 'formValue': '<?= $_POST['a'] ?>',

- };

- window.opener.postMessage(data, '*');

-} else {

- document.writeln('FAIL');

- testRunner.notifyDone();

+mainTestWindow = window.open("", "mainTestWindow")

+var data = {

+ 'method': '<?=$_SERVER['REQUEST_METHOD'] ?>',

+ 'formValue': '<?= $_POST['a'] ?>',

+};

+mainTestWindow.postMessage(data, '*');

</script>