Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 2417973002: Removed incorrect comment about raw pointer. (Closed)

Created:
4 years, 2 months ago by rune
Modified:
4 years, 2 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed incorrect comment about raw pointer. LocalFrame now traced as Member of MediaValuesDynamic. R=meade@chromium.org Committed: https://crrev.com/201585d73b60b9043147deee9e21a8c8b4b916a5 Cr-Commit-Position: refs/heads/master@{#425629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/MediaValuesDynamic.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
rune
ptal
4 years, 2 months ago (2016-10-14 10:52:49 UTC) #2
meade_UTC10
lgtm
4 years, 2 months ago (2016-10-17 02:59:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417973002/1
4 years, 2 months ago (2016-10-17 05:45:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 07:52:57 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 07:55:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/201585d73b60b9043147deee9e21a8c8b4b916a5
Cr-Commit-Position: refs/heads/master@{#425629}

Powered by Google App Engine
This is Rietveld 408576698