Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: gpu/config/gpu_control_list.h

Issue 241793002: Fix machine_model behaviors in gpu blacklist. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/config/gpu_blacklist_unittest.cc ('k') | gpu/config/gpu_control_list.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/config/gpu_control_list.h
diff --git a/gpu/config/gpu_control_list.h b/gpu/config/gpu_control_list.h
index 34d112b669f85d1e5573b612565db50da0e5eb2e..c3f1cf6fda87544b3fd1effacdcfc3bc83904541 100644
--- a/gpu/config/gpu_control_list.h
+++ b/gpu/config/gpu_control_list.h
@@ -265,26 +265,6 @@ class GPU_EXPORT GpuControlList {
bool value_;
};
- class GPU_EXPORT MachineModelInfo {
- public:
- MachineModelInfo(const std::string& name_op,
- const std::string& name_value,
- const std::string& version_op,
- const std::string& version_string,
- const std::string& version_string2);
- ~MachineModelInfo();
-
- // Determines if a given name/version is included in the MachineModelInfo.
- bool Contains(const std::string& name, const std::string& version) const;
-
- // Determines if the MachineModelInfo contains valid information.
- bool IsValid() const;
-
- private:
- scoped_ptr<StringInfo> name_info_;
- scoped_ptr<VersionInfo> version_info_;
- };
-
class GpuControlListEntry;
typedef scoped_refptr<GpuControlListEntry> ScopedGpuControlListEntry;
@@ -419,11 +399,11 @@ class GPU_EXPORT GpuControlList {
const std::string& float_string,
const std::string& float_string2);
- bool SetMachineModelInfo(const std::string& name_op,
- const std::string& name_value,
- const std::string& version_op,
- const std::string& version_string,
- const std::string& version_string2);
+ bool AddMachineModelName(const std::string& model_name);
+
+ bool SetMachineModelVersionInfo(const std::string& version_op,
+ const std::string& version_string,
+ const std::string& version_string2);
bool SetGpuCountInfo(const std::string& op,
const std::string& int_string,
@@ -469,7 +449,8 @@ class GPU_EXPORT GpuControlList {
scoped_ptr<FloatInfo> perf_graphics_info_;
scoped_ptr<FloatInfo> perf_gaming_info_;
scoped_ptr<FloatInfo> perf_overall_info_;
- scoped_ptr<MachineModelInfo> machine_model_info_;
+ std::vector<std::string> machine_model_name_list_;
+ scoped_ptr<VersionInfo> machine_model_version_info_;
scoped_ptr<IntInfo> gpu_count_info_;
scoped_ptr<BoolInfo> direct_rendering_info_;
std::set<int> features_;
« no previous file with comments | « gpu/config/gpu_blacklist_unittest.cc ('k') | gpu/config/gpu_control_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698