remoting/protocol/jingle_session_manager.h - Issue 2417913002: Process incoming IQs in the same order that they were sent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/jingle_session_manager.h

Issue 2417913002: Process incoming IQs in the same order that they were sent. (Closed)

Patch Set: Reviewer's feedback Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/protocol/jingle_session_manager.h

diff --git a/remoting/protocol/jingle_session_manager.h b/remoting/protocol/jingle_session_manager.h

index 6a1fe4fb23024c17bbaa45290d7f43954dcb6054..28fbd2bb4146e3e5b7455f86129a3de3c2eac325 100644

--- a/remoting/protocol/jingle_session_manager.h

+++ b/remoting/protocol/jingle_session_manager.h

@@ -57,7 +57,7 @@ class JingleSessionManager : public SessionManager,

typedef std::map<std::string, JingleSession*> SessionsMap;

IqSender* iq_sender() { return iq_sender_.get(); }

- void SendReply(const buzz::XmlElement* original_stanza,

+ void SendReply(std::unique_ptr<buzz::XmlElement> original_stanza,

JingleMessageReply::ErrorType error);

// Called by JingleSession when it is being destroyed.