Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.h

Issue 2417853002: [css-grid] Implementing the grid's first line baseline. (Closed)
Patch Set: Patch for landing. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-baseline-must-respect-grid-order.html ('K') | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-painting-respect-dom-order-expected.html ('k') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutGrid.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.h b/third_party/WebKit/Source/core/layout/LayoutGrid.h
index a04b97cbc7001c52ece7d3b24e96cc8346abdb4f..1120d29db7ad5d6fd91ede5ff683c2d89f81d05f 100644
--- a/third_party/WebKit/Source/core/layout/LayoutGrid.h
+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.h
@@ -301,6 +301,14 @@ class LayoutGrid final : public LayoutBlock {
void updateAutoMarginsInColumnAxisIfNeeded(LayoutBox&);
void updateAutoMarginsInRowAxisIfNeeded(LayoutBox&);
+ int baselinePosition(
+ FontBaseline,
+ bool firstLine,
+ LineDirectionMode,
+ LinePositionMode = PositionOnContainingLine) const override;
+ int firstLineBoxBaseline() const override;
+ int inlineBlockBaseline(LineDirectionMode) const override;
+
#if ENABLE(ASSERT)
bool tracksAreWiderThanMinTrackBreadth(GridTrackSizingDirection,
GridSizingData&) const;
« third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-baseline-must-respect-grid-order.html ('K') | « third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-painting-respect-dom-order-expected.html ('k') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698