Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-baseline-margins.html

Issue 2417853002: [css-grid] Implementing the grid's first line baseline. (Closed)
Patch Set: Patch for landing. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-baseline-margins.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-baseline-margins.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-baseline-margins.html
new file mode 100644
index 0000000000000000000000000000000000000000..c1d75cabed466109bb2793e21e8ff0ac9330bc43
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-baseline-margins.html
@@ -0,0 +1,81 @@
+<!DOCTYPE html>
+<link href="resources/grid.css" rel="stylesheet">
+<style>
+.column { grid-auto-flow: column; }
+.inline-block { display: inline-block; }
+.grid, .inline-grid { background-color: lightgrey; }
+.border { border: 11px solid pink; }
+.padding { padding: 13px; }
+.margin { margin: 8px 0; }
+.grid > div {
+ min-width: 0;
+ min-height: 0;
Manuel Rego 2016/10/25 19:42:08 Just out of curiosity, why do you need this?
jfernandez 2016/10/26 14:22:31 It's just legacy, with the purpose of dealing with
+}
+</style>
+<p>This test ensures that Baseline Alignment works for 1-dimensional Grid like in Flexible Box, even using margins, paddings and borders.</p>
+<div>
+before text
+<div class="border" style="display: inline-block; background-color: lightgrey">
+<div class="grid" style="height: 30px; margin-top: 7px; padding-top: 10px;">
+ baseline
+</div>
+</div>
+after text
+</div>
+
+<div>
+Should align
+<div class="inline-block border">
+ <div class="grid column padding" style="grid-template-columns: 50px; grid-template-rows: 50px; background-color: pink">
+ <div style="background-color: lightgrey"></div>
+ </div>
+</div>
+with the
+<div class="inline-block margin">
+ <div class="grid column border" style="grid-template-columns: 50px; grid-template-rows: 50px; background-color: pink">
+ <div style="background-color: lightgrey"></div>
+ </div>
+</div>
+bottom of
+<div class="inline-block padding" style="padding-left: 0; padding-right: 0">
+ <div class="grid column margin border" style="grid-template-columns: 50px; grid-template-rows: 50px; background-color: pink">
+ <div style="background-color: lightgrey;"></div>
+ </div>
+</div>
+the grey
+<div class="inline-grid column margin border" style="grid-template-columns: 30px; grid-template-rows: 30px;"></div>
+box.
+</div>
+
+<div>
+Should align
+with the
+<div class="inline-block">
+ <div class="grid column" style="background-color: pink">
+ <div class="border padding margin" style="background-color: lightgrey;"></div>
+ </div>
+</div>
+middle of
+<div class="inline-grid column margin border padding"></div>
+the grey box.
+</div>
+
+<div>
+Should align with the top
+<div class="inline-block border margin padding" style="background-color: pink">
+ <div class="grid column border margin padding" style="grid-template-columns: 50px; grid-template-rows: 50px; background-color: pink">
+ <div style="overflow: scroll; background-color: lightgrey; margin-top: 4px; border-top: 9px solid pink;"></div>
+ </div>
+</div>
+of the horizontal scrollbar.
+</div>
+
+<div>
+Should align 10px above the
+<div class="inline-block" style="background-color: pink">
+ <div class="grid column" style="grid-template-columns: 50px; grid-template-rows: 50px; background-color: pink">
+ <div style="overflow: scroll; padding-bottom: 10px; background-color: lightgrey;"></div>
+ </div>
+</div>
+horizontal scrollbar, if one is visible.
+</div>

Powered by Google App Engine
This is Rietveld 408576698