Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2417833002: Fix test-parsing/InnerAssignment to test what it intended (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com, rossberg
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix test-parsing/InnerAssignment to test what it intended BUG= Committed: https://crrev.com/41f51fe3efbdca98200c4e3bc67536339548dd99 Cr-Commit-Position: refs/heads/master@{#40259}

Patch Set 1 #

Patch Set 2 : Use unique_ptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -27 lines) Patch
M test/cctest/test-parsing.cc View 1 3 chunks +33 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-10-13 12:01:38 UTC) #2
marja
lgtm once you update this to 2016
4 years, 2 months ago (2016-10-13 12:12:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2417833002/20001
4 years, 2 months ago (2016-10-13 12:13:56 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-13 12:37:37 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 12:38:00 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/41f51fe3efbdca98200c4e3bc67536339548dd99
Cr-Commit-Position: refs/heads/master@{#40259}

Powered by Google App Engine
This is Rietveld 408576698