Fix Browser Controller to not reuse iFrames, which can sometimes cause bad state to be left between…

tools/testing/dart/browser_controller.dart

Index: tools/testing/dart/browser_controller.dart
diff --git a/tools/testing/dart/browser_controller.dart b/tools/testing/dart/browser_controller.dart
index 92166e4f788b424211354f59806752045cd20ca5..7e235ce8ea7807f8ae3b004f9b801e233fb247f5 100644
--- a/tools/testing/dart/browser_controller.dart
+++ b/tools/testing/dart/browser_controller.dart
@@ -1374,13 +1374,18 @@ class BrowserTestingServer {
         number_div.innerHTML = number_of_tests;
         executing_div.innerHTML = url;
         if (use_iframe) {
+          var embedded_iframe = document.getElementById('embedded_iframe');
+          embedded_iframe.parentNode.removeChild(embedded_iframe);

[Jennifer Messerly, 2014/04/17 22:29:05]

you might need to remove it from
https://developer.mozilla.org/en-US/docs/Web/API/Window.frames too. not 100%
sure, but it'd be worth checking that list isn't getting bigger.

+
+          embedded_iframe = document.createElement('iframe');
+          embedded_iframe.id = 'embedded_iframe';
+          document.body.appendChild(embedded_iframe);
           embedded_iframe.src = url;
         } else {
-          if (testing_window == undefined) {
-            testing_window = window.open(url);
-          } else {
-            testing_window.location = url;
+          if (testing_window != undefined) {
+            testing_window.close();
           }
+          testing_window = window.open(url);
         }
       }