Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 241783002: Plumbs through delta_largest_observed from (Closed)

Created:
6 years, 8 months ago by ramant (doing other things)
Modified:
6 years, 8 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Plumbs through delta_largest_observed from QuicSentPackerManager::HandleAckForSentPacket, up to the QuicAckNotifier. Eventually these values get to the QuicFasterStatsGatherer which now performs a more accurate RT calculation. The important changes are in QuicSentPacketManager (pulling the delta out of ReceivedInfo), and in QuicFasterStatsGatherer (doing the new calculation of RT). The rest is plumbing and updating tests. Improve accuracy of QUIC FasterStats RT calculation by using the delta time included with delayed ACKs. Merge internal change: 64721749 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -53 lines) Patch
M net/quic/quic_ack_notifier.h View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_ack_notifier.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/quic_ack_notifier_manager.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_ack_notifier_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/quic/quic_ack_notifier_test.cc View 3 chunks +28 lines, -11 lines 0 comments Download
M net/quic/quic_connection_test.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 6 chunks +14 lines, -8 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 8 chunks +17 lines, -15 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 8 months ago (2014-04-17 21:54:53 UTC) #1
Ryan Hamilton
6 years, 8 months ago (2014-04-18 03:33:48 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698